logging changes #1049
Merged
logging changes #1049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nullfunc
requested review from
lionello and
jordanstephens
and removed request for
lionello
jordanstephens
approved these changes
Mar 10, 2025
| @@ -27,7 +27,6 @@ func fixupPort(port *composeTypes.ServicePortConfig) { | |||
| term.Debugf("port %d: ignoring 'published: %s' in 'ingress' mode", port.Target, port.Published) | |||
| } | |||
| if (port.Protocol == Protocol_TCP || port.Protocol == Protocol_UDP) && port.AppProtocol != "http" { | |||
| // term.Warnf("TCP ingress is not supported; assuming HTTP (remove 'protocol' to silence)") | |||
There was a problem hiding this comment.
Why remove this? seems helpful to me
There was a problem hiding this comment.
I can keep the text for documentation and remove the term.Warnf part, don't want it to seem like stale/old code.
Co-authored-by: Jordan Stephens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First go at updating CLI logs.
Linked Issues
link
Checklist