Skip to content

Add provider model docs #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

Add provider model docs #229

merged 1 commit into from
May 14, 2025

Conversation

lionello
Copy link
Member

Adding docs for the new provider: feature that's available in Defang v1.1.21.

jordanstephens
jordanstephens approved these changes May 14, 2025
View reviewed changes
Copy link
Member

@jordanstephens jordanstephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first step! I'd love to see a bit of discussion about why one would want to do this, but this is helpful.

Prakash-Sundaresan
Prakash-Sundaresan reviewed May 14, 2025
View reviewed changes
Copy link
Contributor

@Prakash-Sundaresan Prakash-Sundaresan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs seem fine but they claim x-defang-llm is now supported in Playground. Don't we need code changes for that?

@lionello
Copy link
Member Author

lionello commented May 14, 2025 •
edited
Loading

The docs seem fine but they claim x-defang-llm is now supported in Playground. Don't we need code changes for that?

That was done in https://github.com/DefangLabs/defang-mvp/pull/1759

@lionello lionello merged commit 8158798 into main May 14, 2025
4 checks passed
@lionello lionello deleted the lio/docker-provider branch May 14, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prakash-Sundaresan Prakash-Sundaresan Prakash-Sundaresan left review comments

@jordanstephens jordanstephens jordanstephens approved these changes

@commit111 commit111 Awaiting requested review from commit111

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lionello @jordanstephens @Prakash-Sundaresan