Skip to content

Add report error #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add report error #40

wants to merge 2 commits into from

Conversation

shinin-light
Copy link
Contributor

This PR requires merging and publishing of https://github.com/DeepCodeAI/tsc/pull/12/files first.

@shinin-light shinin-light requested a review from Arvi3d June 2, 2020 15:11
@@ -86,19 +86,23 @@ class DeepCodeErrorHandler implements DeepCode.ErrorHandlerInterface {
error: DeepCode.errorType,
options: { [key: string]: any }
): Promise<void> {
if (process.env.NODE_ENV === "production") {
if (process.env.NODE_ENV === "production" || extension.baseURL !== extension.defaultBaseURL) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe !== should be === ?

@Arvi3d Arvi3d deleted the add_report_error branch June 19, 2020 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants