Skip to content

txn input validation (length, mismatch prevout) #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 6, 2021

Conversation

fuxingloh
Copy link
Contributor

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

Attempting to sign a txn without any vout will fail.
Attempting to sign a txn input P2WPKH will fail if provided prevout and elliptic pair are mismatched.

Which issue(s) does this PR fixes?:

Fixes #134

@fuxingloh fuxingloh added this to the Jellyfish Wallet milestone May 6, 2021
@fuxingloh fuxingloh marked this pull request as ready for review May 6, 2021 07:25
@fuxingloh fuxingloh enabled auto-merge (squash) May 6, 2021 07:25
@github-actions
Copy link

github-actions bot commented May 6, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/jellyfish.umd.js 18.88 KB (0%) 378 ms (0%) 173 ms (+3.27% 🔺) 550 ms

@netlify
Copy link

netlify bot commented May 6, 2021

Deploy preview for jellyfish-defi ready!

Built with commit 000b84d

https://deploy-preview-190--jellyfish-defi.netlify.app

@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #190 (000b84d) into main (9619db1) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #190      +/-   ##
==========================================
+ Coverage   96.02%   96.15%   +0.12%     
==========================================
  Files          58       64       +6     
  Lines        1483     1559      +76     
  Branches      169      187      +18     
==========================================
+ Hits         1424     1499      +75     
- Misses         59       60       +1     
Impacted Files Coverage Δ
packages/jellyfish-transaction/src/tx_signature.ts 97.75% <100.00%> (+0.31%) ⬆️
packages/testing/src/token.ts 100.00% <0.00%> (ø)
packages/testing/src/wallet.ts 100.00% <0.00%> (ø)
packages/testing/src/index.ts 100.00% <0.00%> (ø)
packages/testing/src/poolpair.ts 100.00% <0.00%> (ø)
packages/testing/src/rawtx.ts 92.30% <0.00%> (ø)
packages/testing/src/account.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6e67bf...000b84d. Read the comment docs.

@fuxingloh fuxingloh disabled auto-merge May 6, 2021 09:03
@fuxingloh fuxingloh merged commit 278fa8c into main May 6, 2021
@fuxingloh fuxingloh deleted the fuxingloh/txn-signing-validation branch May 6, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jellyfish-transaction p2wpkh should check elliptic pair before signing transaction
2 participants