Skip to content

fix test as signature length should not be compared #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2021

Conversation

fuxingloh
Copy link
Contributor

What kind of PR is this?:

/kind fix

What this PR does / why we need it:

  1. 30440220
  2. 30430220

DER signature length should not be compared in the test as it's a variable number.

@github-actions
Copy link

github-actions bot commented May 3, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/jellyfish.umd.js 18.87 KB (0%) 378 ms (0%) 185 ms (+6.08% 🔺) 562 ms

@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #178 (2fd7be5) into main (a969279) will decrease coverage by 0.40%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
- Coverage   95.50%   95.10%   -0.41%     
==========================================
  Files          56       56              
  Lines        1180     1185       +5     
  Branches      149      150       +1     
==========================================
  Hits         1127     1127              
- Misses         50       55       +5     
  Partials        3        3              
Impacted Files Coverage Δ
packages/testcontainers/src/chains/container.ts 84.54% <100.00%> (-4.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c4a076...2fd7be5. Read the comment docs.

@fuxingloh fuxingloh marked this pull request as ready for review May 3, 2021 05:42
@fuxingloh fuxingloh requested a review from canonbrother as a code owner May 3, 2021 05:42
@fuxingloh fuxingloh enabled auto-merge (squash) May 3, 2021 05:42
@fuxingloh fuxingloh merged commit 057e820 into main May 3, 2021
@fuxingloh fuxingloh deleted the fuxingloh/raw-txn-signature-not-compare branch May 3, 2021 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/fix Fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants