Skip to content

fix(cli): Correct cross encoder parameter usage #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

Davidyz
Copy link
Owner

@Davidyz Davidyz commented May 1, 2025

Fix #106

@Davidyz Davidyz added bug Something isn't working fix labels May 1, 2025
Copy link

codecov bot commented May 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.16%. Comparing base (8727832) to head (ca4371e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   99.16%   99.16%           
=======================================
  Files          22       22           
  Lines        1431     1432    +1     
=======================================
+ Hits         1419     1420    +1     
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Davidyz Davidyz changed the title fix(cli): Correct reranker parameter usage fix(cli): Correct cross encoder parameter usage May 1, 2025
@Davidyz Davidyz merged commit 141bf87 into main May 1, 2025
12 checks passed
@Davidyz Davidyz deleted the cli/fix-reranker-params branch May 1, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] CrossEncoder.__init__() got an unexpected keyword argument 'model_name_or_path'
1 participant