Skip to content

Remove profiles support #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 24, 2025
Merged

Remove profiles support #1047

merged 8 commits into from
Feb 24, 2025

Conversation

velo
Copy link
Collaborator

@velo velo commented Feb 3, 2025

Initial PR just removing profiles support

@velo velo force-pushed the remove_templating branch from 44d93e3 to 3a452e4 Compare February 4, 2025 19:20
@velo velo changed the title Remove freemarker templating support Remove profiles support Feb 5, 2025
@velo velo force-pushed the remove_templating branch 4 times, most recently from 90b987b to 06df81f Compare February 6, 2025 14:08
@velo velo requested a review from mbroecheler February 7, 2025 13:45
@velo velo force-pushed the remove_templating branch 2 times, most recently from 2765453 to eeb5bf4 Compare February 10, 2025 16:17
Copy link
Contributor

@mbroecheler mbroecheler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Some comments inline

Copy link
Contributor

@mbroecheler mbroecheler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is mostly there - thank you very much. See comments for handling of the default package json and merging of use provided package.json files.

@velo velo force-pushed the remove_templating branch from 7133e37 to d59189c Compare February 19, 2025 18:00
@velo velo requested a review from mbroecheler February 19, 2025 18:01
@velo velo force-pushed the remove_templating branch from 1efadb6 to 4ab1b20 Compare February 20, 2025 14:12
Copy link
Contributor

@mbroecheler mbroecheler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have one minor suggestion for how to make the methods more obvious and have less code duplication.

@velo velo force-pushed the remove_templating branch from dc408fb to a84f032 Compare February 24, 2025 17:37
@velo
Copy link
Collaborator Author

velo commented Feb 24, 2025

$ docker run -ti --rm  ghcr.io/datasqrl/cmd:pr-1047 compile --help
Compiling...this takes about 10 seconds
Unknown option: '--help'
Usage: datasqrl compile [-t=<targetDir>] [-a=<generateAPI>]...
                        [-c=<packageFiles>]... [<files>...]
Compiles an SQRL script and produces all build artifacts
      [<files>...]           Main script and (optional) API specification
  -a, --api=<generateAPI>    Generates the API specification for the given type
  -c, --config=<packageFiles>
                             Package configuration file(s)
  -t, --target=<targetDir>   Target directory for deployment artifacts

Just tested my latest snapshot, working as expected. --profiles is gone

@velo velo merged commit ea7218e into main Feb 24, 2025
3 checks passed
@velo velo deleted the remove_templating branch February 24, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants