-
Notifications
You must be signed in to change notification settings - Fork 16
Remove profiles support #1047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove profiles support #1047
Conversation
44d93e3
to
3a452e4
Compare
90b987b
to
06df81f
Compare
2765453
to
eeb5bf4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work. Some comments inline
sqrl-tools/sqrl-cli/src/main/java/com/datasqrl/cmd/AbstractCompilerCommand.java
Outdated
Show resolved
Hide resolved
sqrl-tools/sqrl-cli/src/test/java/com/datasqrl/cmd/AssertStatusHook.java
Show resolved
Hide resolved
sqrl-tools/sqrl-config/src/main/java/com/datasqrl/config/SqrlConfigCommons.java
Show resolved
Hide resolved
sqrl-tools/sqrl-packager/src/main/java/com/datasqrl/cmd/PackageBootstrap.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is mostly there - thank you very much. See comments for handling of the default package json and merging of use provided package.json files.
7133e37
to
d59189c
Compare
1efadb6
to
4ab1b20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I have one minor suggestion for how to make the methods more obvious and have less code duplication.
...tion-tests/src/test/java/com/datasqrl/discovery/FlexibleSchemaInferencePreprocessorTest.java
Outdated
Show resolved
Hide resolved
sqrl-tools/sqrl-config/src/main/java/com/datasqrl/config/SqrlConfigCommons.java
Outdated
Show resolved
Hide resolved
sqrl-tools/sqrl-packager/src/main/java/com/datasqrl/cmd/PackageBootstrap.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Marvin Froeder <[email protected]>
Signed-off-by: Marvin Froeder <[email protected]>
Signed-off-by: Marvin Froeder <[email protected]>
Signed-off-by: Marvin Froeder <[email protected]>
Signed-off-by: Marvin Froeder <[email protected]>
Signed-off-by: Marvin Froeder <[email protected]>
dc408fb
to
a84f032
Compare
Just tested my latest snapshot, working as expected. |
Initial PR just removing profiles support