Skip to content

Refactor DataSqrlRun & DataSqrlTest #1233

@mbroecheler

Description

@mbroecheler

These two classes have a lot of code duplication with the planner and many hard-coded configuration values which is a maintenance hazard.
DataSqrlRun copies the entire FlinkSQL and compiled plan execution logic from the flink-sql-runner project. We want to figure out a way to reuse flink-sql-runner here because that reduced duplication and makes sure we execute flink-sql-runner which increases its test coverage.

Proposal:
Have the module contianing those two classes depend on the planner and runner. Then we can reuse the configuration system and flink-sql-runner for execution. It also means we can create a single jar file which greatly reduces the size of the docker image.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Status

Done

Relationships

None yet

Development

No branches or pull requests

Issue actions