Skip to content

[synthetics_test] Fix provider crash due to absent 'relative_position' in config #3067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2025
Merged

[synthetics_test] Fix provider crash due to absent 'relative_position' in config #3067

merged 1 commit into from
Jun 27, 2025

Conversation

Alexis-Jacob-datadog
Copy link
Contributor

@Alexis-Jacob-datadog Alexis-Jacob-datadog commented Jun 23, 2025 •
edited
Loading

The provider would encounter a panic error if relative_position for mobile test was empty or not present in the configuration.
This PR resolves that issue.

@Alexis-Jacob-datadog Alexis-Jacob-datadog requested review from a team as code owners June 23, 2025 16:35
@Alexis-Jacob-datadog Alexis-Jacob-datadog changed the title Fix provider crash due to absent 'relative_position' in config [synthetics_test] Fix provider crash due to absent 'relative_position' in config Jun 23, 2025
@Alexis-Jacob-datadog Alexis-Jacob-datadog marked this pull request as draft June 24, 2025 07:12
@Alexis-Jacob-datadog Alexis-Jacob-datadog force-pushed the alexis.jacob/SYNTH-20535/ignore-relativePositions-if-empty branch from fa54e66 to bb12393 Compare June 24, 2025 07:37
@Alexis-Jacob-datadog Alexis-Jacob-datadog marked this pull request as ready for review June 24, 2025 07:38
@Alexis-Jacob-datadog
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 24, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-06-24 11:23:15 UTC ℹ️ Start processing command /merge

2025-06-24 11:23:21 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-06-24 15:24:10 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@Alexis-Jacob-datadog
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 27, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-06-27 07:41:22 UTC ℹ️ Start processing command /merge

2025-06-27 07:41:29 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-06-27 07:53:17 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request

@Supam
Copy link
Member

Supam commented Jun 27, 2025

/remove

@dd-devflow
Copy link

dd-devflow bot commented Jun 27, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-06-27 07:53:12 UTC ℹ️ Start processing command /remove

2025-06-27 07:53:15 UTC ℹ️ Devflow: /remove

@Alexis-Jacob-datadog Alexis-Jacob-datadog force-pushed the alexis.jacob/SYNTH-20535/ignore-relativePositions-if-empty branch from bb12393 to 1eec71e Compare June 27, 2025 08:57
@Alexis-Jacob-datadog
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 27, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-06-27 09:19:46 UTC ℹ️ Start processing command /merge

2025-06-27 09:19:51 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 26m (p90).

2025-06-27 09:42:21 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit e591a45 into master Jun 27, 2025
20 checks passed
@dd-mergequeue dd-mergequeue bot deleted the alexis.jacob/SYNTH-20535/ignore-relativePositions-if-empty branch June 27, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpighi fpighi fpighi approved these changes

@Drarig29 Drarig29 Drarig29 approved these changes

Assignees
No one assigned
Labels
changelog/bugfix mergequeue-status: done resource/datadog_synthetics_test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Alexis-Jacob-datadog @Supam @fpighi @Drarig29