Skip to content

adds fixes for workshops #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2024
Merged

adds fixes for workshops #74

merged 1 commit into from
May 6, 2024

Conversation

arosenkranz
Copy link
Collaborator

  • updates puppeteer scripts to be less brittle
  • fixes ads java service (who knew it would turn all headers lowercase?!)
  • adds error handling for ads errors
  • updates taxonomy pages to use SSR and not client-side rendering, to also address puppeteer brittleness

@arosenkranz arosenkranz self-assigned this May 6, 2024
stanleegoodspeed
stanleegoodspeed approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@stanleegoodspeed stanleegoodspeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good here 👍

@arosenkranz arosenkranz mentioned this pull request May 6, 2024
Closed
@arosenkranz arosenkranz merged commit 6d8cef2 into main May 6, 2024
@arosenkranz arosenkranz deleted the dash-workshop-fixes branch May 6, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanleegoodspeed stanleegoodspeed stanleegoodspeed approved these changes

Assignees

@arosenkranz arosenkranz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arosenkranz @stanleegoodspeed