Datadogfleetautomation extension POC #5272
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
extension/datadogfleetautomationextension/fleetautomationextension.go
Outdated
Show resolved
Hide resolved
extension/datadogfleetautomationextension/fleetautomationextension.go
Outdated
Show resolved
Hide resolved
extension/datadogfleetautomationextension/fleetautomationextension.go
Outdated
Show resolved
Hide resolved
extension/datadogfleetautomationextension/fleetautomationextension_test.go
Outdated
Show resolved
Hide resolved
extension/datadogfleetautomationextension/fleetautomationextension.go
Outdated
Show resolved
Hide resolved
extension/datadogfleetautomationextension/fleetautomationextension.go
Outdated
Show resolved
Hide resolved
|
Addressing the golint violations |
jackgopack4
force-pushed
the
datadogfleetautomation-extension
branch
5 times, most recently
from
cb116ca to
34ae621
Compare
jackgopack4
requested review from
ankitpatel96,
liustanley,
songy23,
mackjmr,
jade-guiton-dd,
IbraheemA and
billmeyer
as code owners
jackgopack4
force-pushed
the
datadogfleetautomation-extension
branch
from
34ae621 to
48930cd
Compare
dineshg13
requested changes
Mar 4, 2025
extension/datadogfleetautomationextension/fleetautomationextension.go
Outdated
Show resolved
Hide resolved
| // Copyright The OpenTelemetry Authors | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| package datadogfleetautomationextension // import "github.com/open-telemetry/opentelemetry-collector-contrib/extension/datadogfleetautomationextension" |
There was a problem hiding this comment.
may be name it datadogfaextension ?
There was a problem hiding this comment.
I don't care that strongly about it; should it be datadogfaextension, datadogrcextension, or just datadogextension @mx-psi @dineshg13 @ancostas
extension/datadogfleetautomationextension/fleetautomationextension.go
Outdated
Show resolved
Hide resolved
jackgopack4
force-pushed
the
datadogfleetautomation-extension
branch
from
48930cd to
9effea7
Compare
mx-psi
requested changes
Mar 5, 2025
extension/datadogfleetautomationextension/fleetautomationextension.go
Outdated
Show resolved
Hide resolved
extension/datadogfleetautomationextension/fleetautomationextension.go
Outdated
Show resolved
Hide resolved
extension/datadogfleetautomationextension/fleetautomationextension.go
Outdated
Show resolved
Hide resolved
jackgopack4
force-pushed
the
datadogfleetautomation-extension
branch
2 times, most recently
from
7bb0557 to
3176d4f
Compare
jackgopack4
force-pushed
the
datadogfleetautomation-extension
branch
from
3176d4f to
e7ed96a
Compare
jackgopack4
force-pushed
the
datadogfleetautomation-extension
branch
from
74751e2 to
9fdf059
Compare
agreed. I will break it up into the 2-3 PRs that the collector-contrib repo requires, at a minimum. https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#adding-new-components |
|
leaving open for now to use as a reference for proposing the separate PRs into upstream contrib |
jackgopack4
force-pushed
the
prod
branch
3 times, most recently
from
a7f57cf to
38837c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
initial POC for Datadog Fleet Automation Extension
Link to tracking issue
Fixes Jira OTEL-2445
Testing
Full unit testing (todo: will open a card to write a few integration tests)
Documentation
Have only written a barebones README.md to pass checks; figured that would make sense to do after we make changes or add/remove/adjust functionality.
Additional notes
Does not yet send the new, third payload type. I am working on a separate branch to add that payload and am planning to open a second PR after this one is accepted to our fork