-
Notifications
You must be signed in to change notification settings - Fork 1k
Add Node Scheduling options for Private Action Runner #1895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
nicholas-at-corteva
wants to merge
13
commits into
DataDog:main
from
nicholas-at-corteva:par_add_nodeselector_and_tolerations
Closed
Add Node Scheduling options for Private Action Runner #1895
nicholas-at-corteva
wants to merge
13
commits into
DataDog:main
from
nicholas-at-corteva:par_add_nodeselector_and_tolerations
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add nodeSelector, tolerations, affinity to the Private Actions Runner chart
merge the changes from main branch
Co-authored-by: datadog-githubops-containers[bot] <152526959+datadog-githubops-containers[bot]@users.noreply.github.com> Co-authored-by: tbavelier <[email protected]> Signed-off-by: nicholas-at-corteva <[email protected]>
…g#1892) Signed-off-by: nicholas-at-corteva <[email protected]>
* Do not mount /etc/passwd if agent is running unprivileged * fix type * add type cast * docs * Try to handle nil case * Try again to handle nil case * Refactor helper * use new helper inside should-add-host-path-for-etc-passwd * nit whitespace * Update changelog and version after merging main --------- Co-authored-by: Timothée Bavelier <[email protected]> Co-authored-by: Timothée Bavelier <[email protected]> Signed-off-by: nicholas-at-corteva <[email protected]>
* [ACTP] add support for kubernetes deployments actions * [ACTP] add required permissions for rollback deployment
….com/nicholas-at-corteva/helm-charts into par_add_nodeselector_and_tolerations
closed, to make a cleaner mr with the verified sigs #1896 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add nodeSelector, tolerations, affinity to the Private Actions Runner chart
What this PR does / why we need it:
Adds the increased flexibility for how the private action runner pods are scheduled to nodes in the cluster
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
<chartName>/minor-version
,<chartName>/patch-version
, or<chartName>/no-version-bump
)GitHub CI takes care of the below, but are still required:
.github/helm-docs.sh
)CHANGELOG.md
has been updatedREADME.md