Skip to content

Add Node Scheduling options for Private Action Runner #1895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nicholas-at-corteva
Copy link
Contributor

Add nodeSelector, tolerations, affinity to the Private Actions Runner chart

What this PR does / why we need it:

Adds the increased flexibility for how the private action runner pods are scheduled to nodes in the cluster

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version semver bump label added (use <chartName>/minor-version, <chartName>/patch-version, or <chartName>/no-version-bump)

GitHub CI takes care of the below, but are still required:

  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md

Add nodeSelector, tolerations, affinity to the Private Actions Runner chart
@nicholas-at-corteva nicholas-at-corteva requested a review from a team as a code owner June 2, 2025 13:46
@nicholas-at-corteva nicholas-at-corteva marked this pull request as draft June 2, 2025 13:48
merge the changes from main branch
@nicholas-at-corteva nicholas-at-corteva marked this pull request as ready for review June 2, 2025 13:55
@nicholas-at-corteva nicholas-at-corteva requested a review from a team as a code owner June 2, 2025 13:55
@nicholas-at-corteva nicholas-at-corteva marked this pull request as draft June 2, 2025 13:59
@nicholas-at-corteva nicholas-at-corteva marked this pull request as ready for review June 2, 2025 14:03
@nicholas-at-corteva nicholas-at-corteva marked this pull request as draft June 2, 2025 14:04
@nicholas-at-corteva nicholas-at-corteva changed the title Add Node Scheducling options for Private Action Runner Add Node Scheduling options for Private Action Runner Jun 2, 2025
tobz and others added 6 commits June 2, 2025 09:11
Co-authored-by: datadog-githubops-containers[bot] <152526959+datadog-githubops-containers[bot]@users.noreply.github.com>
Co-authored-by: tbavelier <[email protected]>
Signed-off-by: nicholas-at-corteva <[email protected]>
* Do not mount /etc/passwd if agent is running unprivileged

* fix type

* add type cast

* docs

* Try to handle nil case

* Try again to handle nil case

* Refactor helper

* use new helper inside should-add-host-path-for-etc-passwd

* nit whitespace

* Update changelog and version after merging main

---------

Co-authored-by: Timothée Bavelier <[email protected]>
Co-authored-by: Timothée Bavelier <[email protected]>
Signed-off-by: nicholas-at-corteva <[email protected]>
* [ACTP] add support for kubernetes deployments actions

* [ACTP] add required permissions for rollback deployment
@nicholas-at-corteva nicholas-at-corteva marked this pull request as ready for review June 2, 2025 14:19
@nicholas-at-corteva nicholas-at-corteva marked this pull request as draft June 2, 2025 14:19
@nicholas-at-corteva nicholas-at-corteva marked this pull request as ready for review June 2, 2025 14:20
@nicholas-at-corteva nicholas-at-corteva marked this pull request as draft June 2, 2025 14:21
@nicholas-at-corteva nicholas-at-corteva marked this pull request as ready for review June 2, 2025 14:25
@nicholas-at-corteva nicholas-at-corteva marked this pull request as draft June 2, 2025 14:26
@nicholas-at-corteva
Copy link
Contributor Author

nicholas-at-corteva commented Jun 2, 2025

closed, to make a cleaner mr with the verified sigs #1896

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants