Skip to content

OTAGENT-386 Add protocol support for DDOT ports #1845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

krlv
Copy link
Contributor

@krlv krlv commented Apr 29, 2025

What this PR does / why we need it:

  1. Adds protocol support to datadog.otelCollector.ports to enable non-TCP receivers like StatsD (requires 8125 UDP port). The protocol field defaults to TCP for backward compatibility.

Example usage for StatsD UDP receiver:

datadog:
  otelCollector:
    enabled: true
    ports:
      - containerPort: 8125
        hostPort: 8125
        name: otel-statsd
  1. Wire up agents.containers.otelAgent.ports parameter to allow additional port configurations for otel-agent container (for debugging, custom extensions, etc.)

Example usage for zPages extension:

agents:
  containers:
    otelAgent:
      ports:
        - containerPort: 55679
          name: otel-zpages

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version semver bump label added (use <chartName>/minor-version, <chartName>/patch-version, or <chartName>/no-version-bump)
  • For datadog or datadog-operator chart or value changes, update the test baselines (run: make update-test-baselines)

GitHub CI takes care of the below, but are still required:

  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md

krlv added 2 commits April 28, 2025 17:42
Add protocol support to `datadog.otelCollector.ports` to enable non-TCP receivers
like StatsD (requires 8125 UDP port). The protocol field defaults to TCP
for backward compatibility.

Example usage for StatsD UDP receiver:

```yaml
datadog:
  otelCollector:
    enabled: true
    ports:
      - containerPort: 8125
        hostPort: 8125
        name: otel-statsd
        protocol: UDP
```
Wire up `agents.containers.otelAgent.ports` parameter to allow auxiliary port
configurations for debugging, custom extensions, etc.

Example usage for zPages extension:

```yaml
agents:
  containers:
    otelAgent:
      ports:
        - containerPort: 55679
          name: otel-zpages
```
@krlv krlv added chart/datadog This issue or pull request is related to the datadog chart datadog/minor-version Minor version bump for datadog chart labels Apr 29, 2025
@krlv krlv requested a review from a team as a code owner April 29, 2025 07:35
name: {{ .name }}
{{- end }}
{{- if .Values.agents.containers.otelAgent.ports }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats the benefit of adding a new agents.containers.otelAgent.ports vs using the existing datadog.otelCollector.ports ?

Base automatically changed from krlv/OTAGENT-387_otel-agent_configmap to main May 3, 2025 02:10
@krlv krlv force-pushed the krlv/OTAGENT-386_override_port_protocol branch 2 times, most recently from 2ca68d1 to 9e499f1 Compare May 6, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart/datadog This issue or pull request is related to the datadog chart datadog/minor-version Minor version bump for datadog chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants