Skip to content

[AGENTRUN-230] Add support for a fips_mode value that will add the -fips image tagSuffix #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
May 7, 2025

Conversation

jeremy-hanna
Copy link
Contributor

@jeremy-hanna jeremy-hanna commented Apr 23, 2025

What this PR does / why we need it:

This PR adds a new value that will provide -fips as an image tagSuffix for both the agent and DCA to utilize their respective FIPS builds (eg. agent, and cluster-agent)

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version semver bump label added (use <chartName>/minor-version, <chartName>/patch-version, or <chartName>/no-version-bump)
  • For datadog or datadog-operator chart or value changes, update the test baselines (run: make update-test-baselines)

GitHub CI takes care of the below, but are still required:

  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md

@github-actions github-actions bot added the chart/datadog This issue or pull request is related to the datadog chart label Apr 23, 2025
@misteriaud misteriaud added the datadog/minor-version Minor version bump for datadog chart label May 6, 2025
@misteriaud misteriaud marked this pull request as ready for review May 6, 2025 11:58
@misteriaud misteriaud requested a review from a team as a code owner May 6, 2025 11:58
misteriaud and others added 4 commits May 6, 2025 18:22
- bump version for datadog to 3.112.0 (minor-version)
- update changelog version for datadog to 3.112.0
- update readme for datadog
Copy link

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small suggestions!

@celenechang
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 7, 2025

View all feedbacks in Devflow UI.

2025-05-07 18:22:26 UTC ℹ️ Start processing command /merge


2025-05-07 18:22:33 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 41m (p90).


2025-05-07 19:01:23 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 5f05966 into main May 7, 2025
34 checks passed
@dd-mergequeue dd-mergequeue bot deleted the jeremy.hanna/add-support-for-fips-mode-toggle branch May 7, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart/datadog This issue or pull request is related to the datadog chart datadog/minor-version Minor version bump for datadog chart mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants