-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
admission-controller should have access to get replicationcontrollers
#1800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update readme for datadog
fanny-jiang
reviewed
Apr 7, 2025
fanny-jiang
reviewed
Apr 7, 2025
@fanny-jiang Updated the PR |
hmahmood
approved these changes
Apr 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For NPM owned files
fanny-jiang
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chart/datadog
This issue or pull request is related to the datadog chart
chart/datadog-crds
This issue or pull request is related to the datadog-crds chart
datadog/patch-version
Patch version bump for datadog chart
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When running in an openshift cluster, you can use a
DeploymentConfig
to configure your application, this will create aReplicationController
instead of aReplicaSet
:https://docs.redhat.com/en/documentation/openshift_container_platform/4.3/html/applications/deployments#what-deployments-are
We don't support this specific kind of resource in our permissions so a user can get this error in the
tagsFromLabels
mutating webhook (depending on the owner of the pod).Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
<chartName>/minor-version
,<chartName>/patch-version
, or<chartName>/no-version-bump
)datadog
ordatadog-operator
chart or value changes, update the test baselines (run:make update-test-baselines
)GitHub CI takes care of the below, but are still required:
.github/helm-docs.sh
)CHANGELOG.md
has been updatedREADME.md