Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admission-controller should have access to get replicationcontrollers #1800

Merged
merged 5 commits into from
Apr 8, 2025

Conversation

stanistan
Copy link
Member

@stanistan stanistan commented Apr 7, 2025

What this PR does / why we need it:

When running in an openshift cluster, you can use a DeploymentConfig to configure your application, this will create a ReplicationController instead of a ReplicaSet:

https://docs.redhat.com/en/documentation/openshift_container_platform/4.3/html/applications/deployments#what-deployments-are

We don't support this specific kind of resource in our permissions so a user can get this error in the tagsFromLabels mutating webhook (depending on the owner of the pod).

ERROR | (pkg/clusteragent/admission/mutate/tagsfromlabels/mutator.go:93 in MutatePod) | replicationcontrollers "XXXXXX" is forbidden: User "system:serviceaccount:datadog:datadog-agent-cluster-agent" cannot get resource "replicationcontrollers" in API group "" in the namespace "XXXXXXX"

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version semver bump label added (use <chartName>/minor-version, <chartName>/patch-version, or <chartName>/no-version-bump)
  • For datadog or datadog-operator chart or value changes, update the test baselines (run: make update-test-baselines)

GitHub CI takes care of the below, but are still required:

  • Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
  • CHANGELOG.md has been updated
  • Variables are documented in the README.md

@stanistan stanistan requested a review from a team as a code owner April 7, 2025 15:42
@github-actions github-actions bot added the chart/datadog This issue or pull request is related to the datadog chart label Apr 7, 2025
@stanistan stanistan requested a review from a team as a code owner April 7, 2025 15:50
@stanistan stanistan requested a review from matthewleese April 7, 2025 15:50
@github-actions github-actions bot added the chart/datadog-crds This issue or pull request is related to the datadog-crds chart label Apr 7, 2025
@stanistan stanistan added the datadog/patch-version Patch version bump for datadog chart label Apr 7, 2025
- update readme for datadog
@fanny-jiang fanny-jiang added datadog/patch-version Patch version bump for datadog chart and removed datadog/patch-version Patch version bump for datadog chart labels Apr 7, 2025
@fanny-jiang fanny-jiang closed this Apr 7, 2025
@fanny-jiang fanny-jiang reopened this Apr 7, 2025
@stanistan
Copy link
Member Author

@fanny-jiang Updated the PR

Copy link
Contributor

@hmahmood hmahmood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For NPM owned files

@fanny-jiang fanny-jiang merged commit 7d7493f into main Apr 8, 2025
28 checks passed
@fanny-jiang fanny-jiang deleted the stanistan/replicationcontrollers-rbac branch April 8, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chart/datadog This issue or pull request is related to the datadog chart chart/datadog-crds This issue or pull request is related to the datadog-crds chart datadog/patch-version Patch version bump for datadog chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants