Skip to content

Docs10767/azure vm guide #29122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 2, 2025
Merged

Docs10767/azure vm guide #29122

merged 5 commits into from
May 2, 2025

Conversation

buraizu
Copy link
Contributor

@buraizu buraizu commented May 2, 2025

What does this PR do? What is the motivation?

Update an instruction and screenshot to account for a metric's deprecation

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@buraizu buraizu requested a review from a team as a code owner May 2, 2025 16:50
@github-actions github-actions bot added Images Images are added/removed with this PR Guide Content impacting a guide labels May 2, 2025
Copy link
Contributor

github-actions bot commented May 2, 2025

Preview links (active after the build_preview check completes)

Modified Files

@buraizu buraizu added WORK IN PROGRESS No review needed, it's a wip ;) and removed WORK IN PROGRESS No review needed, it's a wip ;) labels May 2, 2025
@drichards-87 drichards-87 self-assigned this May 2, 2025
Copy link
Contributor

@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question on the PR. Approving it so you can go ahead and merge if it's not relevant.

The integration does not collect performance metrics for stopped/deallocated machines. However, the `azure.vm.status metric` returns `1` if the machine is running, or stopped (which results in stopped VMs showing up in the infrastructure list). The associated status tag allows you to differentiate between running and not-running hosts. Make sure the host in question has `status:running`, and is running in the Azure portal.
{{< img src="integrations/guide/azure_vms_appearing_in_the_app_without_metrics/azure_vm_running.png" alt="a pair of timeseries graphs in the Datadog application, with one displaying the sum of azure.vm.status with status:running and the other displaying the sum of azure.vm.status with status:not_running" >}}

The integration does not collect performance metrics for stopped or deallocated machines. Use the `azure.vm.count metric` and the `status` tag values of `running`, `stopped`, and `stopped_deallocated` to determine the status of your hosts. Make sure the host in question has `status:running`, and is running in the Azure portal.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to double-check whether the word "metric" in azure.vm.count metric is meant to be formatted as code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for flagging that! Updated in 04990bf

@buraizu
Copy link
Contributor Author

buraizu commented May 2, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 2, 2025

View all feedbacks in Devflow UI.

2025-05-02 20:22:51 UTC ℹ️ Start processing command /merge


2025-05-02 20:22:55 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 20m (p90).


2025-05-02 20:39:46 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 21233bd into master May 2, 2025
17 of 19 checks passed
@dd-mergequeue dd-mergequeue bot deleted the docs10767/azure-vm-guide branch May 2, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Guide Content impacting a guide Images Images are added/removed with this PR mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants