Skip to content

[SYNTH-19390] Update pl config #29113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2025

Conversation

SKYWy
Copy link
Contributor

@SKYWy SKYWy commented May 2, 2025

What does this PR do? What is the motivation?

Update PL options.

Reference (maxAPIDownloadBodySize and maxAPIBodySizeIfProcessed, apiRequestMaxTimeout) :

{
	maxAPIDownloadBodySize: {
	    defaultDescription: '50Mb',
	    description: 'Maximum HTTP body size for a download, in bytes.',
	    type: 'number',
	  },
	  maxAPIBodySizeIfProcessed: {
	    defaultDescription: '5Mb',
	    description: 'Maximum HTTP body size for an assertion, in bytes.',
	    type: 'number',
	  },
	  apiRequestMaxTimeout: {
	    default: defaultConfig.apiRequestMaxTimeout,
	    description: 'Maximum test execution duration for API tests, in milliseconds.',
	    type: 'number',
	  }
}

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

Signed-off-by: Katia SHANG <[email protected]>
Copy link
Contributor

github-actions bot commented May 2, 2025

Preview links (active after the build_preview check completes)

Modified Files

@SKYWy SKYWy marked this pull request as ready for review May 2, 2025 14:08
@SKYWy SKYWy requested a review from a team as a code owner May 2, 2025 14:08
@drichards-87 drichards-87 self-assigned this May 2, 2025
Copy link
Contributor

@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few minor suggestions on the PR.

Signed-off-by: Katia SHANG <[email protected]>
@SKYWy SKYWy requested a review from drichards-87 May 5, 2025 08:44
Copy link
Contributor

@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@drichards-87
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 5, 2025

View all feedbacks in Devflow UI.

2025-05-05 14:44:16 UTC ℹ️ Start processing command /merge


2025-05-05 14:44:29 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 20m (p90).


2025-05-05 15:01:40 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit d3265de into master May 5, 2025
19 of 21 checks passed
@dd-mergequeue dd-mergequeue bot deleted the katia.shang/SYNTH-19390/update-pl-options branch May 5, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants