Skip to content

[CCM] Hierarchical budgets and upload via CSV #29081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 2, 2025

Conversation

rtrieu
Copy link
Contributor

@rtrieu rtrieu commented Apr 30, 2025

What does this PR do? What is the motivation?

This adds details about 2 new features introduced to the CCM Budgets page:

  • Ability to create a hierarchical budget, in addition to a basic budget
  • Ability to upload a budget via CSV, in addition to inputting details manually into the UI

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@rtrieu rtrieu added the WORK IN PROGRESS No review needed, it's a wip ;) label Apr 30, 2025
@rtrieu rtrieu requested a review from a team as a code owner April 30, 2025 20:51
@rtrieu rtrieu requested a review from klara-kr April 30, 2025 20:51
@github-actions github-actions bot added the Images Images are added/removed with this PR label Apr 30, 2025
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@klara-kr klara-kr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@rtrieu rtrieu removed the WORK IN PROGRESS No review needed, it's a wip ;) label May 2, 2025
@drichards-87 drichards-87 self-assigned this May 2, 2025
Copy link
Contributor

@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I just have a couple suggestions and some comments re: the screenshots.

@rtrieu rtrieu requested a review from drichards-87 May 2, 2025 20:33
@drichards-87
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 2, 2025

View all feedbacks in Devflow UI.

2025-05-02 21:27:35 UTC ℹ️ Start processing command /merge


2025-05-02 21:27:39 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 20m (p90).


2025-05-02 21:45:29 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 9eedc38 into master May 2, 2025
17 of 19 checks passed
@dd-mergequeue dd-mergequeue bot deleted the rtrieu/docs-10732-ccm-budgets branch May 2, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Images Images are added/removed with this PR mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants