(fleet) simplify proxy configuration #29024
Open
+1,213
−1,180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview links (active after the
|
|
Created editorial card for our Agent SME to review further |
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies our proxy documentation by splitting out proxy examples for Squid, HAProxy, and NGINX into their own dedicated pages and streamlining the main proxy documentation to focus on the golden path.
- Introduces a new Squid proxy example with configuration instructions.
- Adds a detailed NGINX proxy example with both HTTP and HTTPS configurations.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| content/en/agent/configuration/proxy_example_squid.md | New Squid proxy example documentation with configuration details. |
| content/en/agent/configuration/proxy_example_nginx.md | New NGINX proxy example documentation outlining both HTTP and HTTPS configurations and related Agent setup instructions. |
sgnn7
reviewed
Apr 30, 2025
|
Just a heads up, I'm going to push some updates to this one instead of doing a straightforward review |
hestonhoffman
approved these changes
May 2, 2025
There was a problem hiding this comment.
Wow, this is so much better than old page! Thanks for taking the time to update this stuff for us. I pushed up some edits and I'm going to go ahead and approve.
Change summary:
- Moved the haproxy and nginx pages to the
faqsection of the docs. The faq section can only be reached if you know the URL. Stuff in there is unindexed by default. This is handy for pages we don't want users to stumble upon, but we like to keep it organized so that support can find these pages if they need them. - I didn't move the squid file and I've switched that one to indexed. If we're recommending it as an option for users who don't have a dedicated proxy server, it needs to be findable. But I've added some language to the top of the page directing them back to the main doc if they do have a proxy server. I also added this file to the sidenav, nested under the proxy doc
- Lots of style / signposting edits
github-actions
bot
added
Architecture
brooklynebkbk
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies our proxy documentation: