Skip to content

Make the classpath seperator in jmxfetch adjust to the os #3729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2018
Merged

Make the classpath seperator in jmxfetch adjust to the os #3729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions jmxfetch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,11 +240,11 @@ def _start(self, path_to_java, java_run_opts, jmx_checks, command, reporter, too

classpath = path_to_jmxfetch
if tools_jar_path is not None:
classpath = r"%s:%s" % (tools_jar_path, classpath)
classpath = r"%s%s%s" % (tools_jar_path, os.pathsep, classpath)
if custom_jar_paths:
classpath = r"%s:%s" % (':'.join(custom_jar_paths), classpath)
classpath = r"%s%s%s" % (os.pathsep.join(custom_jar_paths), os.pathsep, classpath)
if self.config_jar_path:
classpath = r"%s:%s" % (self.config_jar_path, classpath)
classpath = r"%s%s%s" % (self.config_jar_path, os.pathsep, classpath)

subprocess_args = [
path_to_java, # Path to the java bin
Expand Down