-
Notifications
You must be signed in to change notification settings - Fork 18
Handle invalid UTF-8 characters #678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Datadog Summary✅ Code Quality ✅ Code Security ✅ Dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it's stacked off of #676, if so, for reviewing purposes can you please set the target branch to your other feature branch, until that PR is merged? I was very confused at first as to why a lot of the code was the same here.
Co-authored-by: Amaan Qureshi <[email protected]>
Interesting since I use a different and clean branch. Will revert the other changes for sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved but undo the seemingly accidental newline change to integration-test-secrets.sh
What problem are you trying to solve?
We want to be able to scan files with encoding different than UTF-8
What is your solution?
Change the functions to read files so that
Testing
Added integration tests with the
sast-files-encoding
repository that exposes data with different encodings.