[STAL-2456] feat: add PHP support #444
Merged
+40
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonforal
reviewed
Jul 12, 2024
jasonforal
approved these changes
Jul 12, 2024
|
squashing & merging |
amaanq
force-pushed
the
amaan.qureshi/add-php
branch
from
596da90 to
f7f1f07
Compare
jasonforal
added a commit
that referenced
this pull request
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are you trying to solve?
Currently, we do not support PHP files. We need a way to parse and query PHP files, but we do not currently fetch and build a PHP grammar.
What is your solution?
Add the PHP grammar to the analyzer itself, which is fetched from https://github.com/tree-sitter/tree-sitter-php. This will allow us (and customers down the line) to begin writing rules targeting PHP files.
Alternatives considered
What the reviewer should know