[STAL-2057] Hardcode include testing rules in CLI #359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are you trying to solve?
When using the Analyzer via the CLI, all rules, including testing rules, should be included.
What is your solution?
By hard-coding that all rules, including testing rules, should be pulled from the API, we remove the complexity associated with parameterizing whether or not testing rules should be included. The con of including testing rules by default is virtually only that additional results are in the resulting SARIF file. When the SARIF file gets sent to Datadog, violations from testing rules are hidden in the UI by default (but is easily accessed via a toggle). The pro of including testing rules by default is that it reduces the number of places a user needs to specify that testing rules should be included.
Alternatives considered
exclude_testing_rules
instead ofinclude_testing_rules
. The con of this is that we'd need to change the semantics of this feature in many places.What the reviewer should know