feat: DD_LAMBDA_FIPS_MODE handling for metrics #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apiarian-datadog
force-pushed
the
aleksandr.pasechnik/svls-6240-fipsish-metrics
branch
from
a345715 to
cf8b847
Compare
duncanista
approved these changes
May 9, 2025
hghotra
approved these changes
May 9, 2025
joeyzhao2018
approved these changes
May 10, 2025
|
Tested this by running it in our self-monitoring system. We are correctly pick picking up the configuration and defaults. |
Datadog Summary✅ Code Quality ✅ Code Security ❌ Dependencies Next StepsFix these dependency issues introduced by this PR: ⚫ Critical: stdlib 1.21
⚫ Critical: stdlib 1.23.0
🟠 Medium: golang.org/x/net 0.23.0
🟠 Medium: golang.org/x/net 0.33.0
Was this helpful? Give us feedback! |
apiarian-datadog
deleted the
aleksandr.pasechnik/svls-6240-fipsish-metrics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Correctly handles the
DD_LAMBDA_FIPS_MODEcontrol, same as we do in the python and js layers.We no longer support direct Datadog API metric submission when
DD_LAMBDA_FIPS_MODEis enabled. This setting is enabled by default in govcloud. Various mechanisms are provided to override this configuration value.Please note that we did not previously actually send metrics with timestamps to the extension. Metrics with timestamps get turned into metrics with timestamp=now. This is still the behavior after this change.
Testing Guidelines
Added some unit tests. Will also deploy to self-monitoring.
Types of changes
Checklist