Use JWT to get GH Token #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously I thought that we could use the JWT to as the token for github, but we actually need to use that to get the github token, and then everything else should work the same. I tried this by checking the auth status on a test run, and it seems to work.
TalUsvyatsky
approved these changes
Jun 18, 2025
ava-silver
approved these changes
Jun 18, 2025
|
|
||
| # Write private key to a temporary file | ||
| PRIVATE_KEY_FILE=$(mktemp) | ||
| echo "$GH_PRIVATE_KEY" > "$PRIVATE_KEY_FILE" | ||
|
|
||
| # Get the GH token | ||
| export GH_TOKEN=$(bash serverless/tools/generate_jwt.sh $GH_APP_ID $PRIVATE_KEY_FILE) | ||
| export JWT_TOKEN=$(bash serverless/tools/generate_jwt.sh $GH_APP_ID $PRIVATE_KEY_FILE) |
There was a problem hiding this comment.
nit
Suggested change
| export JWT_TOKEN=$(bash serverless/tools/generate_jwt.sh $GH_APP_ID $PRIVATE_KEY_FILE) | |
| export JWT_TOKEN=$(bash serverless/tools/generate_jwt.sh "$GH_APP_ID" "$PRIVATE_KEY_FILE") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Previously I thought that we could use the JWT to as the token for github, but we actually need to use that to get the github token, and then everything else should work the same. I tried this by checking the auth status on a test run, and it seems to work.
Motivation
Unblock releases
Testing Guidelines
See
gh auth statuspass hereAdditional Notes
Types of changes
Check all that apply