[dependencies] upgrade proxy agent to version 4.0.1 #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-rousse
force-pushed
the
mrousse/upgrade_proxy_agent
branch
from
4d757cb to
9eb9f24
Compare
yoannmoinet
approved these changes
May 7, 2021
Comment on lines
+105
to
+106
| const proxyUrl = getProxyUrl(this.proxyOpts) | ||
| options.agent = new ProxyAgent(proxyUrl) |
lefebvree
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Goal of this PR is to update the
netmasknested dependency to fix a critical vulnerability.It does so by updating the
proxy-agentdependency from major 3.x to major 4.x. It should not introduce breaking changes from our perspective, it upgrades the underlying dependencyagent-basefrom v4 to v6 (cf. TooTallNate/node-proxy-agent#55) which itself changes the way options are passed to the proxy agent.Review checklist