-
Notifications
You must be signed in to change notification settings - Fork 1.3k
disable THP by default in system-probe and the security-agent #38493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 664666f Optimization Goals: ✅ No significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | quality_gate_logs | % cpu utilization | +0.56 | [-2.19, +3.31] | 1 | Logs bounds checks dashboard |
➖ | ddot_metrics | memory utilization | +0.29 | [+0.17, +0.40] | 1 | Logs |
➖ | quality_gate_idle | memory utilization | +0.26 | [+0.19, +0.34] | 1 | Logs bounds checks dashboard |
➖ | docker_containers_cpu | % cpu utilization | +0.19 | [-2.86, +3.24] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | +0.18 | [+0.12, +0.23] | 1 | Logs |
➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.13 | [+0.09, +0.18] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | +0.10 | [-0.57, +0.77] | 1 | Logs |
➖ | otlp_ingest_logs | memory utilization | +0.09 | [-0.03, +0.21] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.09 | [-0.14, +0.31] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | +0.08 | [-0.51, +0.66] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.01 | [-0.60, +0.62] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.29, +0.31] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.02, +0.03] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | -0.04 | [-0.65, +0.58] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | -0.05 | [-0.60, +0.50] | 1 | Logs |
➖ | docker_containers_memory | memory utilization | -0.07 | [-0.16, +0.02] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | -0.08 | [-0.69, +0.54] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | -0.14 | [-0.69, +0.41] | 1 | Logs |
➖ | otlp_ingest_metrics | memory utilization | -0.15 | [-0.29, -0.01] | 1 | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.30 | [-1.13, +0.53] | 1 | Logs |
➖ | ddot_logs | memory utilization | -0.48 | [-0.57, -0.38] | 1 | Logs |
➖ | quality_gate_idle_all_features | memory utilization | -1.32 | [-1.37, -1.26] | 1 | Logs bounds checks dashboard |
➖ | file_tree | memory utilization | -2.66 | [-2.75, -2.57] | 1 | Logs |
Bounds Checks: ❌ Failed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
❌ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 9/10 | |
✅ | docker_containers_cpu | simple_check_run | 10/10 | |
✅ | docker_containers_memory | memory_usage | 10/10 | |
✅ | docker_containers_memory | simple_check_run | 10/10 | |
✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for agent-configuration owned files
Can you share details of the benchmarks and results from deployments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good for docs
Given that this is an SMP environment variability issue, I am not sure if this is the best place to solve this. |
/merge |
View all feedbacks in Devflow UI.
The expected merge time in
|
What does this PR do?
This PR disables THP usage in the system-probe and the security-agent by default. After running a lot of benchmarks and internal deployments, we showed that the impact of disabling THPs was neutral or positive, especially in the SMP environment.
Internally we deploy the agent on nodes configured with transparent huge pages configed in madvise mode. This means that only pages that have an additional
madvise
call on them withMADV_HUGEPAGE
will make use of huge pages. The go runtime does not make this call in the general case, meaning that we have deployed the agent internally with THP disabled since basically forever.In SMP benchmarks, the impact of disabling THP allows the system-probe and the security agent to not exhibit extra memory usage at the end of the 10 min run:


baseline:
comparison:
in this particular benchmark the maximum PSS for the total container going from 545MiB to 517MiB with THPs disabled.
Re-enabling THP usage is still possible using the
system_probe_config.disable_thp
orsecurity_agent.disable_thp
configuration options.Motivation
Describe how you validated your changes
Possible Drawbacks / Trade-offs
Additional Notes