-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[ABLD-77] Bump dda
version to bring dmgbuild
for macOS
#38446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
dda
version to bring dmgbuild
for macOSdda
version to bring dmgbuild
for macOS
e37b5a5
to
12eb9ab
Compare
12eb9ab
to
b42d77c
Compare
b42d77c
to
83f93db
Compare
Since available Python build dependencies rely on the version of `dda`, the present change bumps it to bring the `dmgbuild` tool for macOS. See https://github.com/DataDog/datadog-agent-dev/releases/tag/v0.19.0, and esp. DataDog/datadog-agent-dev#137. The PR is kept trivial (revertible) as other changes were brought to `dda` since last bump from March 2025.
83f93db
to
9100fb3
Compare
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: e22b96c Optimization Goals: ✅ No significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | docker_containers_cpu | % cpu utilization | +2.10 | [-1.01, +5.21] | 1 | Logs |
➖ | quality_gate_logs | % cpu utilization | +1.97 | [-0.80, +4.74] | 1 | Logs bounds checks dashboard |
➖ | quality_gate_idle_all_features | memory utilization | +0.66 | [+0.59, +0.73] | 1 | Logs bounds checks dashboard |
➖ | quality_gate_idle | memory utilization | +0.51 | [+0.43, +0.59] | 1 | Logs bounds checks dashboard |
➖ | otlp_ingest_logs | memory utilization | +0.20 | [+0.08, +0.33] | 1 | Logs |
➖ | ddot_metrics | memory utilization | +0.20 | [+0.08, +0.31] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | +0.14 | [-0.50, +0.78] | 1 | Logs |
➖ | ddot_logs | memory utilization | +0.09 | [-0.00, +0.18] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | +0.04 | [-0.52, +0.61] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | +0.04 | [-0.56, +0.65] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.02, +0.03] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.28, +0.27] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | -0.03 | [-0.58, +0.52] | 1 | Logs |
➖ | otlp_ingest_metrics | memory utilization | -0.04 | [-0.19, +0.10] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.05 | [-0.59, +0.49] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | -0.08 | [-0.31, +0.16] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | -0.13 | [-0.72, +0.45] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | -0.14 | [-0.69, +0.41] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -0.35 | [-0.41, -0.29] | 1 | Logs |
➖ | docker_containers_memory | memory utilization | -0.51 | [-0.59, -0.43] | 1 | Logs |
➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -1.17 | [-1.22, -1.12] | 1 | Logs |
➖ | file_tree | memory utilization | -1.25 | [-1.38, -1.12] | 1 | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -1.82 | [-2.65, -0.99] | 1 | Logs |
Bounds Checks: ✅ Passed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
✅ | docker_containers_cpu | simple_check_run | 10/10 | |
✅ | docker_containers_memory | memory_usage | 10/10 | |
✅ | docker_containers_memory | simple_check_run | 10/10 | |
✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
What does this PR do?
Since available Python build dependencies rely on the version of
dda
, the present change bumps it to bring thedmgbuild
tool for macOS.Motivation
See https://github.com/DataDog/datadog-agent-dev/releases/tag/v0.19.0, and esp. DataDog/datadog-agent-dev#137.
Possible Drawbacks / Trade-offs
The PR is kept trivial (revertible) as other changes were brought to
dda
since last bump from March 2025.