-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add download of BTF via Remote Config #38031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: fc62b28 Optimization Goals: ✅ Improvement(s) detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | quality_gate_logs | % cpu utilization | +3.61 | [+0.80, +6.41] | 1 | Logs bounds checks dashboard |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +2.58 | [+1.72, +3.43] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | +1.43 | [+1.37, +1.48] | 1 | Logs |
➖ | docker_containers_memory | memory utilization | +0.46 | [+0.39, +0.53] | 1 | Logs |
➖ | otlp_ingest_logs | memory utilization | +0.39 | [+0.25, +0.52] | 1 | Logs |
➖ | otlp_ingest_metrics | memory utilization | +0.36 | [+0.20, +0.52] | 1 | Logs |
➖ | file_tree | memory utilization | +0.11 | [-0.02, +0.23] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | +0.10 | [-0.50, +0.70] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | +0.07 | [-0.56, +0.70] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.06 | [-0.52, +0.65] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | +0.05 | [-0.52, +0.62] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | +0.04 | [-0.54, +0.61] | 1 | Logs |
➖ | ddot_metrics | memory utilization | +0.03 | [-0.08, +0.15] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.03 | [-0.21, +0.26] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.02, +0.02] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | -0.00 | [-0.60, +0.60] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.28, +0.28] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | -0.09 | [-0.63, +0.45] | 1 | Logs |
➖ | quality_gate_idle | memory utilization | -0.14 | [-0.19, -0.08] | 1 | Logs bounds checks dashboard |
➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | -0.21 | [-0.26, -0.16] | 1 | Logs |
➖ | ddot_logs | memory utilization | -0.22 | [-0.32, -0.13] | 1 | Logs |
➖ | quality_gate_idle_all_features | memory utilization | -0.58 | [-0.67, -0.50] | 1 | Logs bounds checks dashboard |
✅ | docker_containers_cpu | % cpu utilization | -8.84 | [-11.82, -5.86] | 1 | Logs |
Bounds Checks: ✅ Passed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
✅ | docker_containers_cpu | simple_check_run | 10/10 | |
✅ | docker_containers_memory | memory_usage | 10/10 | |
✅ | docker_containers_memory | simple_check_run | 10/10 | |
✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
d9b031d
to
6ee0014
Compare
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
|
968ac92
to
d59a1a3
Compare
What does this PR do?
Adds the ability to download BTF from remote config, if BTF is not found via other supported means.
Motivation
Supporting kernels without native BTF that are newer than the packaged BTF shipping with an agent release.
Describe how you validated your changes
Automated tests added
Possible Drawbacks / Trade-offs
Additional Notes
https://datadoghq.atlassian.net/browse/EBPF-416
An e2e test should be added before enabling this feature by default.