Skip to content

ignore errors cleaning up temporary files #36594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2025

Conversation

clarkb7
Copy link
Contributor

@clarkb7 clarkb7 commented May 1, 2025

What does this PR do?

Ignore errors when cleaning up temporary files used to extract the embedded Python distribution

Motivation

https://datadoghq.atlassian.net/browse/WINA-1471
Saw a case where the file was locked and it failed the install. Deleting these files isn't critical so we shouldn't fail the install. We suspect it may have been locked for scanning by an antimalware solution.

Describe how you validated your changes

Our E2E tests already ensure these files are deleted in normal circumstances

Manual steps to reproduce the error:
Run the following command and then run the Agent MSI. It will mark the 7zr.exe file read-only once it's written to disk, preventing it from being deleted.

powershell.exe -Command {
$p="C:\Program Files\Datadog\Datadog Agent\bin\7zr.exe";
while (-not (Test-Path "$p")) { sleep -Milliseconds 500 };
attrib +r "$p"
}

Ensure the install succeeds, the 7zr file still exists on disk, and the following error is present in the MSI log

CA: 15:20:19: DecompressPythonDistribution. Error while deleting C:\Program Files\Datadog\Datadog Agent\bin\7zr.exe: System.UnauthorizedAccessException: Access to the path 'C:\Program Files\Datadog\Datadog Agent\bin\7zr.exe' is denied.
   at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
   at System.IO.File.InternalDelete(String path, Boolean checkHost)
   at Datadog.CustomActions.PythonDistributionCustomAction.DecompressPythonDistribution(ISession session, String outputDirectoryName, String compressedDistributionFile, Int32 pythonDistributionSize)

Possible Drawbacks / Trade-offs

Additional Notes

@github-actions github-actions bot added team/windows-agent short review PR is simple enough to be reviewed quickly labels May 1, 2025
@clarkb7 clarkb7 added the qa/done QA done before merge and regressions are covered by tests label May 1, 2025
@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor a51aa9a585a736ab8d787796dbd2c7491a10c5c0

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 779.64MB 779.64MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 788.58MB 788.58MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 788.58MB 788.58MB 0.50MB
datadog-agent-arm64-deb 0.00MB 769.73MB 769.73MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 778.65MB 778.65MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 31.18MB 31.18MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 31.26MB 31.26MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 31.26MB 31.26MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 30.01MB 30.01MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 367.60MB 367.60MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 60.46MB 60.46MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 60.54MB 60.54MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 60.54MB 60.54MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 57.76MB 57.76MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 57.84MB 57.84MB 0.50MB

Decision

✅ Passed

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 5cdb95bd-97cc-4535-abab-3684dd7f1d1a

Baseline: a51aa9a
Comparison: 9be5bd0
Diff

Optimization Goals: ✅ Improvement(s) detected

perf experiment goal Δ mean % Δ mean % CI trials links
file_tree memory utilization -6.43 [-6.59, -6.26] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +1.62 [+0.68, +2.57] 1 Logs
otlp_ingest_metrics memory utilization +0.22 [+0.07, +0.37] 1 Logs
ddot_logs memory utilization +0.16 [+0.03, +0.29] 1 Logs
quality_gate_logs % cpu utilization +0.16 [-2.62, +2.93] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency_http1 egress throughput +0.00 [-0.64, +0.65] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.02] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.29, +0.29] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.02 [-0.65, +0.61] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.02 [-0.64, +0.59] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.02 [-0.64, +0.59] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.05 [-0.71, +0.62] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.05 [-0.70, +0.60] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.06 [-0.29, +0.18] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.08 [-0.71, +0.55] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.14 [-0.20, -0.08] 1 Logs
ddot_metrics memory utilization -0.21 [-0.33, -0.09] 1 Logs
otlp_ingest_logs memory utilization -0.32 [-0.45, -0.19] 1 Logs
quality_gate_idle memory utilization -0.46 [-0.52, -0.41] 1 Logs bounds checks dashboard
docker_containers_memory memory utilization -0.47 [-0.55, -0.39] 1 Logs
quality_gate_idle_all_features memory utilization -0.58 [-0.67, -0.49] 1 Logs bounds checks dashboard
docker_containers_cpu % cpu utilization -0.61 [-4.37, +3.15] 1 Logs
tcp_syslog_to_blackhole ingress throughput -1.80 [-1.86, -1.74] 1 Logs
file_tree memory utilization -6.43 [-6.59, -6.26] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
docker_containers_cpu simple_check_run 10/10
docker_containers_memory memory_usage 10/10
docker_containers_memory simple_check_run 10/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10 bounds checks dashboard
quality_gate_logs memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks

✅ Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 754.18 MiB 778.06 MiB 184.78 MiB 191.06 MiB
static_quality_gate_agent_deb_amd64_fips 752.18 MiB 776.09 MiB 184.19 MiB 190.72 MiB
static_quality_gate_agent_heroku_amd64 358.64 MiB 434.99 MiB 95.41 MiB 114.34 MiB
static_quality_gate_agent_msi 953.84 MiB 978.45 MiB 146.79 MiB 151.65 MiB
static_quality_gate_agent_rpm_amd64 754.11 MiB 778.06 MiB 186.94 MiB 193.42 MiB
static_quality_gate_agent_rpm_amd64_fips 752.06 MiB 776.06 MiB 186.62 MiB 192.61 MiB
static_quality_gate_agent_rpm_arm64 744.79 MiB 768.33 MiB 168.9 MiB 174.71 MiB
static_quality_gate_agent_rpm_arm64_fips 742.8 MiB 766.55 MiB 168.09 MiB 173.92 MiB
static_quality_gate_agent_suse_amd64 754.24 MiB 778.08 MiB 186.94 MiB 193.42 MiB
static_quality_gate_agent_suse_amd64_fips 752.07 MiB 776.11 MiB 186.62 MiB 192.78 MiB
static_quality_gate_agent_suse_arm64 744.68 MiB 768.31 MiB 168.9 MiB 174.71 MiB
static_quality_gate_agent_suse_arm64_fips 742.79 MiB 766.5 MiB 168.09 MiB 173.92 MiB
static_quality_gate_docker_agent_amd64 848.42 MiB 862.5 MiB 285.45 MiB 292.0 MiB
static_quality_gate_docker_agent_arm64 862.1 MiB 876.0 MiB 272.21 MiB 278.3 MiB
static_quality_gate_docker_agent_jmx_amd64 848.42 MiB 862.5 MiB 285.45 MiB 292.0 MiB
static_quality_gate_docker_agent_jmx_arm64 862.1 MiB 876.63 MiB 272.21 MiB 278.4 MiB
static_quality_gate_docker_agent_windows1809 848.42 MiB 862.5 MiB 285.45 MiB 292.0 MiB
static_quality_gate_docker_agent_windows1809_core 848.42 MiB 862.5 MiB 285.45 MiB 292.0 MiB
static_quality_gate_docker_agent_windows1809_core_jmx 848.42 MiB 862.5 MiB 285.45 MiB 292.0 MiB
static_quality_gate_docker_agent_windows1809_jmx 848.42 MiB 862.5 MiB 285.45 MiB 292.0 MiB
static_quality_gate_docker_agent_windows2022 848.42 MiB 862.5 MiB 285.45 MiB 292.0 MiB
static_quality_gate_docker_agent_windows2022_core 848.42 MiB 862.5 MiB 285.45 MiB 292.0 MiB
static_quality_gate_docker_agent_windows2022_core_jmx 848.42 MiB 862.5 MiB 285.45 MiB 292.0 MiB
static_quality_gate_docker_agent_windows2022_jmx 848.42 MiB 862.5 MiB 285.45 MiB 292.0 MiB
static_quality_gate_docker_cluster_agent_amd64 259.56 MiB 263.4 MiB 101.89 MiB 104.07 MiB
static_quality_gate_docker_cluster_agent_arm64 275.56 MiB 279.38 MiB 96.84 MiB 98.95 MiB
static_quality_gate_docker_cws_instrumentation_amd64 6.66 MiB 7.12 MiB 2.82 MiB 3.29 MiB
static_quality_gate_docker_cws_instrumentation_arm64 6.44 MiB 6.92 MiB 2.6 MiB 3.07 MiB
static_quality_gate_docker_dogstatsd_amd64 37.96 MiB 46.39 MiB 14.64 MiB 17.78 MiB
static_quality_gate_docker_dogstatsd_arm64 36.87 MiB 45.05 MiB 13.72 MiB 16.65 MiB
static_quality_gate_dogstatsd_deb_amd64 29.81 MiB 38.4 MiB 7.89 MiB 10.26 MiB
static_quality_gate_dogstatsd_deb_arm64 28.7 MiB 36.98 MiB 6.87 MiB 8.96 MiB
static_quality_gate_dogstatsd_rpm_amd64 29.81 MiB 38.4 MiB 7.9 MiB 10.27 MiB
static_quality_gate_dogstatsd_suse_amd64 29.81 MiB 38.4 MiB 7.9 MiB 10.27 MiB
static_quality_gate_iot_agent_deb_amd64 57.75 MiB 58.51 MiB 14.54 MiB 15.02 MiB
static_quality_gate_iot_agent_deb_arm64 55.17 MiB 55.94 MiB 12.55 MiB 13.05 MiB
static_quality_gate_iot_agent_deb_armhf 53.94 MiB 54.32 MiB 12.56 MiB 13.05 MiB
static_quality_gate_iot_agent_rpm_amd64 57.75 MiB 58.51 MiB 14.55 MiB 15.04 MiB
static_quality_gate_iot_agent_rpm_arm64 55.17 MiB 55.94 MiB 12.58 MiB 13.07 MiB
static_quality_gate_iot_agent_suse_amd64 57.75 MiB 58.51 MiB 14.55 MiB 15.04 MiB

@clarkb7 clarkb7 marked this pull request as ready for review May 1, 2025 21:03
@clarkb7 clarkb7 requested review from a team as code owners May 1, 2025 21:03
@clarkb7 clarkb7 added the ask-review Ask required teams to review this PR label May 1, 2025
@clarkb7
Copy link
Contributor Author

clarkb7 commented May 2, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 2, 2025

View all feedbacks in Devflow UI.

2025-05-02 13:29:47 UTC ℹ️ Start processing command /merge


2025-05-02 13:29:51 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 43m (p90).


2025-05-02 14:08:09 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit ba182ad into main May 2, 2025
277 of 278 checks passed
@dd-mergequeue dd-mergequeue bot deleted the branden.clark/ignore-delete-fail branch May 2, 2025 14:08
@github-actions github-actions bot added this to the 7.67.0 milestone May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ask-review Ask required teams to review this PR qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/windows-agent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants