Skip to content

Bump go.opentelemetry.io/otel/sdk from 1.34.0 to 1.35.0 #34976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 10, 2025

Bumps go.opentelemetry.io/otel/sdk from 1.34.0 to 1.35.0.

Changelog

Sourced from go.opentelemetry.io/otel/sdk's changelog.

[1.35.0/0.57.0/0.11.0] 2025-03-05

This release is the last to support [Go 1.22]. The next release will require at least [Go 1.23].

Added

  • Add ValueFromAttribute and KeyValueFromAttribute in go.opentelemetry.io/otel/log. (#6180)
  • Add EventName and SetEventName to Record in go.opentelemetry.io/otel/log. (#6187)
  • Add EventName to RecordFactory in go.opentelemetry.io/otel/log/logtest. (#6187)
  • AssertRecordEqual in go.opentelemetry.io/otel/log/logtest checks Record.EventName. (#6187)
  • Add EventName and SetEventName to Record in go.opentelemetry.io/otel/sdk/log. (#6193)
  • Add EventName to RecordFactory in go.opentelemetry.io/otel/sdk/log/logtest. (#6193)
  • Emit Record.EventName field in go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc. (#6211)
  • Emit Record.EventName field in go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp. (#6211)
  • Emit Record.EventName field in go.opentelemetry.io/otel/exporters/stdout/stdoutlog (#6210)
  • The go.opentelemetry.io/otel/semconv/v1.28.0 package. The package contains semantic conventions from the v1.28.0 version of the OpenTelemetry Semantic Conventions. See the migration documentation for information on how to upgrade from go.opentelemetry.io/otel/semconv/v1.27.0(#6236)
  • The go.opentelemetry.io/otel/semconv/v1.30.0 package. The package contains semantic conventions from the v1.30.0 version of the OpenTelemetry Semantic Conventions. See the migration documentation for information on how to upgrade from go.opentelemetry.io/otel/semconv/v1.28.0(#6240)
  • Document the pitfalls of using Resource as a comparable type. Resource.Equal and Resource.Equivalent should be used instead. (#6272)
  • Support [Go 1.24]. (#6304)
  • Add FilterProcessor and EnabledParameters in go.opentelemetry.io/otel/sdk/log. It replaces go.opentelemetry.io/otel/sdk/log/internal/x.FilterProcessor. Compared to previous version it additionally gives the possibility to filter by resource and instrumentation scope. (#6317)

Changed

  • Update github.com/prometheus/common to v0.62.0, which changes the NameValidationScheme to NoEscaping. This allows metrics names to keep original delimiters (e.g. .), rather than replacing with underscores. This is controlled by the Content-Type header, or can be reverted by setting NameValidationScheme to LegacyValidation in github.com/prometheus/common/model. (#6198)

Fixes

  • Eliminate goroutine leak for the processor returned by NewSimpleSpanProcessor in go.opentelemetry.io/otel/sdk/trace when Shutdown is called and the passed ctx is canceled and SpanExporter.Shutdown has not returned. (#6368)
  • Eliminate goroutine leak for the processor returned by NewBatchSpanProcessor in go.opentelemetry.io/otel/sdk/trace when ForceFlush is called and the passed ctx is canceled and SpanExporter.Export has not returned. (#6369)
Commits
  • 5ba5e7a Release v1.35.0/v0.57.0/v0.11.0 (#6407)
  • 3908b67 chore(deps): update module github.com/securego/gosec/v2 to v2.22.2 (#6412)
  • 50172b1 chore(deps): update module github.com/ryancurrah/gomodguard to v1.4.1 (#6411)
  • cea6d2b fix(deps): update module google.golang.org/grpc to v1.71.0 (#6409)
  • e2aee3a Move trace sdk tests from trace_test into trace package (#6400)
  • 38f4f39 fix(deps): update build-tools to v0.20.0 (#6403)
  • 2911449 Look at stale issues in ascending order (#6396)
  • 7cb322a chore(deps): update github.com/golangci/dupl digest to 44c6a0b (#6398)
  • 0c3651e fix(deps): update module github.com/golangci/golangci-lint to v1.64.6 (#6394)
  • f04e951 chore(deps): update mvdan.cc/unparam digest to 0df0534 (#6391)
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added changelog/no-changelog dependencies PRs that bump a dependency dependencies-go PRs that bump a go dependency team/triage labels Mar 10, 2025
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Mar 10, 2025
@github-actions github-actions bot requested a review from a team as a code owner March 10, 2025 21:09
Copy link

cit-pr-commenter bot commented Mar 10, 2025

Go Package Import Differences

Baseline: 920ef42
Comparison: 9b4925b

binaryosarchchange
agentlinuxamd64
+1, -0
+go.opentelemetry.io/otel/trace/internal/telemetry
agentlinuxarm64
+1, -0
+go.opentelemetry.io/otel/trace/internal/telemetry
agentwindowsamd64
+1, -0
+go.opentelemetry.io/otel/trace/internal/telemetry
agentdarwinamd64
+1, -0
+go.opentelemetry.io/otel/trace/internal/telemetry
agentdarwinarm64
+1, -0
+go.opentelemetry.io/otel/trace/internal/telemetry
iot-agentlinuxamd64
+1, -0
+go.opentelemetry.io/otel/trace/internal/telemetry
iot-agentlinuxarm64
+1, -0
+go.opentelemetry.io/otel/trace/internal/telemetry
heroku-agentlinuxamd64
+1, -0
+go.opentelemetry.io/otel/trace/internal/telemetry
cluster-agentlinuxamd64
+1, -0
+go.opentelemetry.io/otel/trace/internal/telemetry
cluster-agentlinuxarm64
+1, -0
+go.opentelemetry.io/otel/trace/internal/telemetry
dogstatsdlinuxamd64
+1, -0
+go.opentelemetry.io/otel/trace/internal/telemetry
dogstatsdlinuxarm64
+1, -0
+go.opentelemetry.io/otel/trace/internal/telemetry
process-agentlinuxamd64
+1, -0
+go.opentelemetry.io/otel/trace/internal/telemetry
process-agentlinuxarm64
+1, -0
+go.opentelemetry.io/otel/trace/internal/telemetry
process-agentwindowsamd64
+1, -0
+go.opentelemetry.io/otel/trace/internal/telemetry
security-agentlinuxamd64
+1, -0
+go.opentelemetry.io/otel/trace/internal/telemetry
security-agentlinuxarm64
+1, -0
+go.opentelemetry.io/otel/trace/internal/telemetry
security-agentwindowsamd64
+1, -0
+go.opentelemetry.io/otel/trace/internal/telemetry
sbomgenlinuxamd64
+1, -0
+go.opentelemetry.io/otel/trace/internal/telemetry
sbomgenlinuxarm64
+1, -0
+go.opentelemetry.io/otel/trace/internal/telemetry
serverlesslinuxamd64
+1, -0
+go.opentelemetry.io/otel/trace/internal/telemetry
serverlesslinuxarm64
+1, -0
+go.opentelemetry.io/otel/trace/internal/telemetry
system-probelinuxamd64
+2, -0
+go.opentelemetry.io/otel/semconv/v1.26.0
+go.opentelemetry.io/otel/trace/internal/telemetry
system-probelinuxarm64
+2, -0
+go.opentelemetry.io/otel/semconv/v1.26.0
+go.opentelemetry.io/otel/trace/internal/telemetry
trace-agentlinuxamd64
+1, -0
+go.opentelemetry.io/otel/trace/internal/telemetry
trace-agentlinuxarm64
+1, -0
+go.opentelemetry.io/otel/trace/internal/telemetry
trace-agentwindowsamd64
+1, -0
+go.opentelemetry.io/otel/trace/internal/telemetry
trace-agentdarwinamd64
+1, -0
+go.opentelemetry.io/otel/trace/internal/telemetry
trace-agentdarwinarm64
+1, -0
+go.opentelemetry.io/otel/trace/internal/telemetry
heroku-trace-agentlinuxamd64
+1, -0
+go.opentelemetry.io/otel/trace/internal/telemetry

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: b121b029-11a2-4c58-8bfd-4a86458f78db

Baseline: 920ef42
Comparison: c485fd7
Diff

Optimization Goals: ✅ Improvement(s) detected

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_idle memory utilization -6.28 [-6.33, -6.22] 1 Logs bounds checks dashboard

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +2.24 [+1.39, +3.09] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.50 [+0.45, +0.56] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.15 [-0.63, +0.92] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.10 [-0.69, +0.89] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.05 [-0.57, +0.66] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.04 [-0.77, +0.85] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.03 [-0.78, +0.84] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.30, +0.30] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.03, +0.02] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.64, +0.61] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.02 [-0.84, +0.80] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.09 [-0.56, +0.38] 1 Logs
quality_gate_logs % cpu utilization -0.60 [-3.37, +2.16] 1 Logs
quality_gate_idle_all_features memory utilization -2.48 [-2.54, -2.42] 1 Logs bounds checks dashboard
file_tree memory utilization -3.95 [-4.06, -3.83] 1 Logs
quality_gate_idle memory utilization -6.28 [-6.33, -6.22] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@L3n41c L3n41c added team/opentelemetry OpenTelemetry team and removed team/triage labels Mar 20, 2025
@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor 920ef4282883d825458ac03c1b2e3a34cc874866

Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 0.46MB ⚠️ 820.05MB 819.59MB 0.50MB
datadog-agent-x86_64-suse 0.46MB ⚠️ 820.05MB 819.59MB 0.50MB
datadog-agent-amd64-deb 0.45MB ⚠️ 810.25MB 809.80MB 0.50MB
datadog-agent-aarch64-rpm 0.43MB ⚠️ 811.00MB 810.57MB 0.50MB
datadog-agent-arm64-deb 0.42MB ⚠️ 801.21MB 800.79MB 0.50MB
datadog-heroku-agent-amd64-deb 0.33MB ⚠️ 440.95MB 440.62MB 0.50MB
datadog-dogstatsd-amd64-deb 0.11MB ⚠️ 39.44MB 39.33MB 0.50MB
datadog-iot-agent-amd64-deb 0.11MB ⚠️ 62.28MB 62.17MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.11MB ⚠️ 39.52MB 39.41MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.11MB ⚠️ 39.52MB 39.41MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.11MB ⚠️ 62.35MB 62.24MB 0.50MB
datadog-iot-agent-x86_64-suse 0.11MB ⚠️ 62.35MB 62.24MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.10MB ⚠️ 59.57MB 59.47MB 0.50MB
datadog-dogstatsd-arm64-deb 0.10MB ⚠️ 37.96MB 37.85MB 0.50MB
datadog-iot-agent-arm64-deb 0.10MB ⚠️ 59.50MB 59.40MB 0.50MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 784.3 MiB 801.8 MiB 191.2 MiB 202.62 MiB
static_quality_gate_agent_deb_arm64 775.64 MiB 793.14 MiB 173.3 MiB 184.51 MiB
static_quality_gate_agent_rpm_amd64 784.24 MiB 801.79 MiB 193.1 MiB 205.03 MiB
static_quality_gate_agent_rpm_arm64 775.63 MiB 793.09 MiB 175.43 MiB 186.44 MiB
static_quality_gate_agent_suse_amd64 784.24 MiB 801.81 MiB 193.1 MiB 205.03 MiB
static_quality_gate_agent_suse_arm64 775.64 MiB 793.14 MiB 175.43 MiB 186.44 MiB
static_quality_gate_dogstatsd_deb_amd64 37.69 MiB 47.67 MiB 9.75 MiB 19.78 MiB
static_quality_gate_dogstatsd_deb_arm64 36.27 MiB 46.27 MiB 8.46 MiB 18.49 MiB
static_quality_gate_dogstatsd_rpm_amd64 37.69 MiB 47.67 MiB 9.77 MiB 19.79 MiB
static_quality_gate_dogstatsd_suse_amd64 37.69 MiB 47.67 MiB 9.77 MiB 19.79 MiB
static_quality_gate_iot_agent_deb_amd64 59.47 MiB 69.0 MiB 14.93 MiB 24.8 MiB
static_quality_gate_iot_agent_deb_arm64 56.82 MiB 66.4 MiB 12.86 MiB 22.8 MiB
static_quality_gate_iot_agent_rpm_amd64 59.47 MiB 69.0 MiB 14.95 MiB 24.8 MiB
static_quality_gate_iot_agent_rpm_arm64 56.82 MiB 66.4 MiB 12.88 MiB 22.8 MiB
static_quality_gate_iot_agent_suse_amd64 59.47 MiB 69.0 MiB 14.95 MiB 24.8 MiB
static_quality_gate_docker_agent_amd64 868.87 MiB 886.12 MiB 292.33 MiB 304.21 MiB
static_quality_gate_docker_agent_arm64 883.52 MiB 900.79 MiB 278.64 MiB 290.47 MiB
static_quality_gate_docker_agent_jmx_amd64 1.04 GiB 1.06 GiB 367.43 MiB 379.33 MiB
static_quality_gate_docker_agent_jmx_arm64 1.05 GiB 1.06 GiB 349.74 MiB 361.55 MiB
static_quality_gate_docker_dogstatsd_amd64 45.84 MiB 55.78 MiB 17.28 MiB 27.28 MiB
static_quality_gate_docker_dogstatsd_arm64 44.46 MiB 54.45 MiB 16.15 MiB 26.16 MiB
static_quality_gate_docker_cluster_agent_amd64 265.02 MiB 274.78 MiB 106.38 MiB 116.28 MiB
static_quality_gate_docker_cluster_agent_arm64 280.97 MiB 290.82 MiB 101.19 MiB 111.12 MiB

Copy link
Contributor Author

dependabot bot commented on behalf of github May 26, 2025

A newer version of go.opentelemetry.io/otel/sdk exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@chouetz
Copy link
Member

chouetz commented Jun 5, 2025

@dependabot recreate

Bumps [go.opentelemetry.io/otel/sdk](https://github.com/open-telemetry/opentelemetry-go) from 1.34.0 to 1.35.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.34.0...v1.35.0)

---
updated-dependencies:
- dependency-name: go.opentelemetry.io/otel/sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/go.opentelemetry.io/otel/sdk-1.35.0 branch from 9b4925b to 1503f08 Compare June 5, 2025 10:51
This commit was created from the local commit with hash 8d515bb527017280c53e4e132418b24bda60f8a4.
@github-actions github-actions bot requested a review from a team as a code owner June 5, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog dependencies PRs that bump a dependency dependencies-go PRs that bump a go dependency short review PR is simple enough to be reviewed quickly team/opentelemetry OpenTelemetry team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants