Skip to content

Feature parity between Python disk check and Go disk check #33116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 198 commits into from
Apr 29, 2025
Merged

Feature parity between Python disk check and Go disk check #33116

Show file tree
Hide file tree
Changes from 75 commits
Commits
Show all changes
198 commits
Select commit Hold shift + click to select a range
5321bc8
add test when 'include_all_devices' is not present (default value=True)
jose-manuel-almaza Jan 20, 2025
2cebed1
add release notes
jose-manuel-almaza Jan 20, 2025
df8d05b
add test when 'include_all_devices' is True
jose-manuel-almaza Jan 20, 2025
5ed612e
add test when 'include_all_devices' is False
jose-manuel-almaza Jan 20, 2025
48b78e0
refactor mocks
jose-manuel-almaza Jan 20, 2025
2a2142d
add test when disk.Partitions returns an error
jose-manuel-almaza Jan 20, 2025
f145f53
add debug logs present in python check
jose-manuel-almaza Jan 20, 2025
447c523
Merge branch 'main' into jose/disk_feature_parity
jose-manuel-almaza Jan 21, 2025
8fb789f
add 'all_partitions' tests
jose-manuel-almaza Jan 22, 2025
1e6b88c
Merge branch 'main' into jose/disk_feature_parity
jose-manuel-almaza Jan 22, 2025
cc5c03c
process 'device_exclude' config key
jose-manuel-almaza Jan 22, 2025
59e568c
process 'device_blacklist' config key
jose-manuel-almaza Jan 22, 2025
8c98e0f
process 'excluded_disks' config key
jose-manuel-almaza Jan 22, 2025
56b2fc5
process 'excluded_disk_re' config key
jose-manuel-almaza Jan 22, 2025
e2abd45
move 'mountpoint' variable closer to its use
jose-manuel-almaza Jan 22, 2025
b514223
small refactor
jose-manuel-almaza Jan 23, 2025
479c31b
process 'device_include' and 'device_whitelist' config keys
jose-manuel-almaza Jan 23, 2025
ddd7058
process 'file_system_exclude', 'file_system_blacklist' and 'excluded_…
jose-manuel-almaza Jan 23, 2025
8b1d5fb
process 'file_system_include' and 'file_system_whitelist' config keys
jose-manuel-almaza Jan 23, 2025
7e7112f
process 'excluded_mountpoint_re' config key
jose-manuel-almaza Jan 23, 2025
931e6c1
process 'include_all_devices' config key
jose-manuel-almaza Jan 23, 2025
28588f1
Merge branch 'main' into jose/disk_feature_parity
jose-manuel-almaza Jan 23, 2025
54b6415
add regular expressions support when excluding devices
jose-manuel-almaza Jan 23, 2025
1220c2d
add regular expressions support when including devices
jose-manuel-almaza Jan 23, 2025
d83947b
add regular expressions support when including/excluding file systems
jose-manuel-almaza Jan 23, 2025
2b17c42
add regular expressions support when excluding mount points
jose-manuel-almaza Jan 23, 2025
5773ad9
process 'mount_point_include' and 'mount_point_whitelist' config keys
jose-manuel-almaza Jan 24, 2025
e458c39
add new asserts for all usage metrics reported
jose-manuel-almaza Jan 24, 2025
fda63ce
add new asserts for 'include_all_devices' config key tests
jose-manuel-almaza Jan 24, 2025
e0f1c42
meaningful test names and new asserts
jose-manuel-almaza Jan 24, 2025
60ce0ff
improve test names and add missing asserts
jose-manuel-almaza Jan 24, 2025
30ab96b
add test when 'diskUsage' system call returns error
jose-manuel-almaza Jan 24, 2025
17ea573
process 'device_global_exclude' and 'device_global_blacklist' config …
jose-manuel-almaza Jan 24, 2025
47b8407
add 'file_system_global_blacklist' deprecation message
jose-manuel-almaza Jan 24, 2025
d0fb680
remove comments
jose-manuel-almaza Jan 27, 2025
e655942
add 'device_global_blacklist' and 'mount_point_global_blacklist' depr…
jose-manuel-almaza Jan 27, 2025
096c7a5
process 'device_global_exclude' error in config
jose-manuel-almaza Jan 27, 2025
835a461
rename tests
jose-manuel-almaza Jan 27, 2025
cedcb2b
add 'file_system_whitelist' deprecation message
jose-manuel-almaza Jan 27, 2025
a53f049
add 'file_system_blacklist' deprecation message
jose-manuel-almaza Jan 27, 2025
6e95e4c
add 'device_whitelist' deprecation message
jose-manuel-almaza Jan 27, 2025
280d939
add 'device_blacklist' deprecation message
jose-manuel-almaza Jan 27, 2025
93d4b35
add 'mount_point_whitelist' deprecation message
jose-manuel-almaza Jan 27, 2025
ec812d4
add 'mount_point_blacklist' deprecation message
jose-manuel-almaza Jan 27, 2025
fc326c9
add 'excluded_filesystems' deprecation message
jose-manuel-almaza Jan 27, 2025
d2cc47d
add 'excluded_disks' and 'excluded_disk_re' deprecation message
jose-manuel-almaza Jan 27, 2025
a18c176
add 'excluded_mountpoint_re' deprecation message
jose-manuel-almaza Jan 27, 2025
c3678ee
process 'min_disk_size' config key
jose-manuel-almaza Jan 27, 2025
430f09d
assert log message when 'diskUsage' system call fails
jose-manuel-almaza Jan 27, 2025
cd36d33
assert log message when partition is excluded because of size check
jose-manuel-almaza Jan 27, 2025
56e3250
Merge branch 'main' into jose/disk_feature_parity
jose-manuel-almaza Jan 27, 2025
47328a1
process 'tag_by_filesystem' config key
jose-manuel-almaza Jan 27, 2025
789ebd9
process 'use_mount' config key
jose-manuel-almaza Jan 27, 2025
5b7d280
process 'device_tag_re' config key
jose-manuel-almaza Jan 28, 2025
eaae963
prevent using the 'use_lsblk' and 'blkid_cache_file' config keys at t…
jose-manuel-almaza Jan 28, 2025
c0efc48
small refactor
jose-manuel-almaza Jan 28, 2025
22fa311
process 'tag_by_label' config key
jose-manuel-almaza Jan 29, 2025
f5c2cd2
add test where 'tag_by_filesystem' configkey is false
jose-manuel-almaza Jan 29, 2025
7358e41
small refactor
jose-manuel-almaza Jan 29, 2025
6f9757e
process 'service_check_rw' config key
jose-manuel-almaza Jan 29, 2025
a103522
add tests for 'disk.IOCounters' use cases
jose-manuel-almaza Jan 29, 2025
e91c367
added logs
jose-manuel-almaza Jan 29, 2025
406ee23
update 'blkid' system call management
jose-manuel-almaza Jan 30, 2025
a1db57e
Merge branch 'main' into jose/disk_feature_parity
jose-manuel-almaza Jan 30, 2025
cf53230
add missing asserts
jose-manuel-almaza Jan 30, 2025
1a297ae
add labels to iocounters metrics
jose-manuel-almaza Jan 30, 2025
36bdaf4
remove some comments
jose-manuel-almaza Jan 30, 2025
2226c50
change warning log message to align with python version
jose-manuel-almaza Jan 31, 2025
82cf824
fix test name error
jose-manuel-almaza Jan 31, 2025
6625b63
fix test
jose-manuel-almaza Jan 31, 2025
46f5713
remove some default exclude values that should be set by config
jose-manuel-almaza Jan 31, 2025
1cc2d0d
use either device name or mount point to get device tags
jose-manuel-almaza Jan 31, 2025
d0da6b8
process 'create_mounts' config key and refactor code
jose-manuel-almaza Feb 10, 2025
94c143c
fix build tags
jose-manuel-almaza Feb 10, 2025
591e5dd
Merge branch 'main' into jose/disk_feature_parity
jose-manuel-almaza Feb 10, 2025
fec08f1
remove previous windows stub
jose-manuel-almaza Feb 10, 2025
102681f
add 'blkid' command call for non-windows
jose-manuel-almaza Feb 11, 2025
3129ef8
update config file
jose-manuel-almaza Feb 11, 2025
6a8653b
process 'use_lsblk' and 'blkid_cache_file'
jose-manuel-almaza Feb 12, 2025
635c68d
Merge branch 'main' into jose/disk_feature_parity
jose-manuel-almaza Feb 12, 2025
a3ab0fd
Merge branch 'main' into jose/disk_feature_parity
jose-manuel-almaza Feb 14, 2025
efddc0d
remove unnecessary comments and build tags
jose-manuel-almaza Feb 17, 2025
8054c4e
fix revive errors
jose-manuel-almaza Feb 17, 2025
33469ed
rename 'diskConfigure' to 'configureDiskCheck'
jose-manuel-almaza Feb 17, 2025
5f4fcf3
remove unneeded conversion
jose-manuel-almaza Feb 17, 2025
e1f5484
remove unneeded conversion
jose-manuel-almaza Feb 17, 2025
b600c2e
Merge branch 'jose/disk_feature_parity' of github.com:DataDog/datadog…
jose-manuel-almaza Feb 17, 2025
63ded7e
add labelRegExpression as const value
jose-manuel-almaza Feb 17, 2025
f8441b5
move a type declaration and method to private
jose-manuel-almaza Feb 17, 2025
4c0c1be
add default values
jose-manuel-almaza Feb 17, 2025
e8f30a4
regex as var
jose-manuel-almaza Feb 17, 2025
ca2e61c
fixed linter error
jose-manuel-almaza Feb 17, 2025
e964ab4
fixed linter error
jose-manuel-almaza Feb 17, 2025
9deeb1a
make device type private
jose-manuel-almaza Feb 18, 2025
38b985e
Merge branch 'main' into jose/disk_feature_parity
jose-manuel-almaza Mar 27, 2025
61f85fa
fixed error
jose-manuel-almaza Mar 27, 2025
8eb5fc0
run unit tests in all platforms
jose-manuel-almaza Mar 27, 2025
cb1d7ca
moved create mounts config read to a method
jose-manuel-almaza Mar 27, 2025
ba6568b
add tests for 'file_system_global_exclude' default values
jose-manuel-almaza Mar 27, 2025
3ea5f79
add tests for 'mount_point_global_exclude' default values
jose-manuel-almaza Mar 27, 2025
314a7e9
moved tag tests to not windows build
jose-manuel-almaza Mar 27, 2025
b1cef97
moved tests to linux or windows
jose-manuel-almaza Mar 28, 2025
bf88dc1
moved some consts to the correct file
jose-manuel-almaza Mar 28, 2025
8f65909
moved 'create_mounts' code to windows
jose-manuel-almaza Mar 28, 2025
1649760
added python comments pointing to issues
jose-manuel-almaza Mar 28, 2025
a3877e0
rename unused variable
jose-manuel-almaza Mar 28, 2025
45ee528
fixed error with some 'min_disk_size' use cases
jose-manuel-almaza Mar 28, 2025
8808c79
add marshall yaml into config
jose-manuel-almaza Apr 1, 2025
edbcd62
small refactor
jose-manuel-almaza Apr 1, 2025
1da5481
add ignore case in windows config regular expressions
jose-manuel-almaza Apr 1, 2025
dbfd9bf
Merge branch 'main' into jose/disk_feature_parity
jose-manuel-almaza Apr 1, 2025
01d20bc
fixed windows test
jose-manuel-almaza Apr 1, 2025
ca42641
removed windows test
jose-manuel-almaza Apr 1, 2025
168bc20
small refactor
jose-manuel-almaza Apr 2, 2025
31b349f
move new implementation from disk to diskv2 folder
jose-manuel-almaza Apr 2, 2025
3e75264
restore disk original version as the new one is now in diskv2 folder
jose-manuel-almaza Apr 2, 2025
375c4cc
set diskv2 as package for diskv2 folder
jose-manuel-almaza Apr 2, 2025
3324ba8
Update pkg/collector/corechecks/system/disk/diskv2/disk_nix.go
jose-manuel-almaza Apr 4, 2025
37b3c0f
Merge branch 'main' into jose/disk_feature_parity
jose-manuel-almaza Apr 4, 2025
0de301d
fixed error
jose-manuel-almaza Apr 4, 2025
515b5fc
skip empty labels
jose-manuel-almaza Apr 4, 2025
c264205
remove unnecessary code when creating remote path
jose-manuel-almaza Apr 4, 2025
f82740f
fixed windows test
jose-manuel-almaza Apr 4, 2025
66dd905
Merge branch 'main' into jose/disk_feature_parity
jose-manuel-almaza Apr 8, 2025
18ef777
add 'use_diskv2_check' config key
jose-manuel-almaza Apr 8, 2025
a6bf013
update release notes
jose-manuel-almaza Apr 8, 2025
1eea9d8
Update releasenotes/notes/disk_feature_parity-f26158df4ead7b63.yaml
jose-manuel-almaza Apr 8, 2025
b1ad617
Update pkg/config/setup/config.go
jose-manuel-almaza Apr 8, 2025
1ca00b2
create remotePath func
jose-manuel-almaza Apr 8, 2025
b85dd06
fixed NetAddConnection calls
jose-manuel-almaza Apr 8, 2025
50ba0ad
fix label regex to be case insensitive
jose-manuel-almaza Apr 9, 2025
67351c6
remove extra initialization
jose-manuel-almaza Apr 9, 2025
ea71057
avoid empty labels
jose-manuel-almaza Apr 9, 2025
fdedd64
fix windows test
jose-manuel-almaza Apr 9, 2025
a16dbf0
add test for empty labels
jose-manuel-almaza Apr 9, 2025
e4f9498
changed log level when partition usage is zero
jose-manuel-almaza Apr 9, 2025
a8d7c48
Update cmd/agent/dist/conf.d/disk.d/conf.yaml.default
jose-manuel-almaza Apr 10, 2025
4827701
small refactor
jose-manuel-almaza Apr 10, 2025
afc9388
Merge branch 'jose/disk_feature_parity' of github.com:DataDog/datadog…
jose-manuel-almaza Apr 10, 2025
c724ac9
move tag logic to a separate function
jose-manuel-almaza Apr 10, 2025
8f1b3f0
add 'lowercase_device_tag' config key
jose-manuel-almaza Apr 11, 2025
d4d65b3
add base_device_name func
jose-manuel-almaza Apr 11, 2025
ad35774
add 'utilized' metrics
jose-manuel-almaza Apr 11, 2025
f1b0584
send inodes metrics only in linux
jose-manuel-almaza Apr 11, 2025
2db79ef
copy comment from python check
jose-manuel-almaza Apr 11, 2025
41fcd5f
skip cd-rom drives in windows
jose-manuel-almaza Apr 11, 2025
35c2879
ignore all the bits not part of the mountpoint name
jose-manuel-almaza Apr 11, 2025
df4d6ac
fix unused-parameter error
jose-manuel-almaza Apr 11, 2025
3e359c7
Update pkg/collector/corechecks/system/disk/diskv2/disk.go
jose-manuel-almaza Apr 11, 2025
b9d7f08
copy 'device_name' related test to windows
jose-manuel-almaza Apr 11, 2025
ef48fd5
copy 'device_name' related test to windows
jose-manuel-almaza Apr 11, 2025
5fea541
fix windows test
jose-manuel-almaza Apr 14, 2025
9ab049f
fix 'include_all_devices' to true test
jose-manuel-almaza Apr 14, 2025
84d31c6
fix 'include_all_devices' to false test
jose-manuel-almaza Apr 14, 2025
27a589e
fix empty device test
jose-manuel-almaza Apr 14, 2025
32c31b5
fix 'all_partitions' to false test
jose-manuel-almaza Apr 14, 2025
b8cf023
fix 'all_partitions' to true test
jose-manuel-almaza Apr 14, 2025
4523119
fix device include and whitelist tests
jose-manuel-almaza Apr 14, 2025
e5422d4
fix cdrom tests
jose-manuel-almaza Apr 14, 2025
20be185
migrate some tests to windows
jose-manuel-almaza Apr 14, 2025
e8f7cbe
fix tracefs tests
jose-manuel-almaza Apr 15, 2025
c967a37
fix 'file_system_global_exclude' tests
jose-manuel-almaza Apr 15, 2025
2472848
fix 'file_system_*' tests
jose-manuel-almaza Apr 15, 2025
0fd01c4
small refactor
jose-manuel-almaza Apr 15, 2025
ef2bb7a
fix 'file_system_include' and 'file_system_whitelist' tests
jose-manuel-almaza Apr 15, 2025
1c114ed
fix mock.AnythingOfType error
jose-manuel-almaza Apr 15, 2025
df5138c
Merge branch 'main' into jose/disk_feature_parity
jose-manuel-almaza Apr 15, 2025
d31c54c
fix 'mount_point_global_exclude' and 'mount_point_global_blacklist' t…
jose-manuel-almaza Apr 15, 2025
17245f2
fix 'mount_point_exclude' and 'mount_point_blacklist' tests
jose-manuel-almaza Apr 15, 2025
6eb9a67
fix 'excluded_mountpoint_re' test
jose-manuel-almaza Apr 15, 2025
2dcde71
fix 'tag_by_filesystem' to true test
jose-manuel-almaza Apr 15, 2025
3ccd034
fix 'use_mount' and 'service_check_rw' to true tests
jose-manuel-almaza Apr 15, 2025
8af93c8
fix TestGivenADiskCheckWithFileSystemGlobalExcludeNotConfigured_WhenC…
jose-manuel-almaza Apr 15, 2025
e6c716a
[AGENTRUN-213] Add disk check e2e test comparing versions (#35990)
pgimalac Apr 16, 2025
08372e0
stop reporting inodes metrics when usage.InodesTotal is 0
jose-manuel-almaza Apr 16, 2025
53ad66f
Merge branch 'main' into jose/disk_feature_parity
jose-manuel-almaza Apr 16, 2025
c465d67
small refactor
jose-manuel-almaza Apr 17, 2025
a94ac80
round to 1 decimal metric values in e2e
jose-manuel-almaza Apr 17, 2025
a8ff7f6
add const metricCompareDecimals set to 1
jose-manuel-almaza Apr 17, 2025
8593390
custom comparer alternative
jose-manuel-almaza Apr 17, 2025
a7d157a
add timeout to disk usage call
jose-manuel-almaza Apr 17, 2025
2fcd4d7
fixed comparer
jose-manuel-almaza Apr 17, 2025
5af9363
remove commented lines
jose-manuel-almaza Apr 17, 2025
a91cc30
Merge branch 'main' into jose/disk_feature_parity
jose-manuel-almaza Apr 17, 2025
a77bee4
feat: add Windows e2e test for disk
pgimalac Apr 23, 2025
7728bac
fix: use os argument to pick the os in e2e tests
pgimalac Apr 23, 2025
f0a9721
Merge branch 'main' into jose/disk_feature_parity
jose-manuel-almaza Apr 23, 2025
b9d3a46
refactor e2e test and fix os problem when calling UpdateEnv
jose-manuel-almaza Apr 24, 2025
0cee8f0
Merge branch 'main' into jose/disk_feature_parity
jose-manuel-almaza Apr 24, 2025
fa784b0
use 'github.com/benbjohnson/clock'
jose-manuel-almaza Apr 28, 2025
d52e624
regexes for filesystem include always case insensitive
jose-manuel-almaza Apr 28, 2025
3045a72
Update pkg/collector/corechecks/system/disk/diskv2/disk.go
jose-manuel-almaza Apr 28, 2025
0711e50
fix import error
jose-manuel-almaza Apr 28, 2025
17f67b2
trim tags
jose-manuel-almaza Apr 28, 2025
8e49460
add warning log for invalid regular expressions
jose-manuel-almaza Apr 28, 2025
40830e8
remove CI_PIPELINE_ID mention
jose-manuel-almaza Apr 28, 2025
bce779a
Merge branch 'main' into jose/disk_feature_parity
jose-manuel-almaza Apr 29, 2025
9d08b86
Merge branch 'main' into jose/disk_feature_parity
jose-manuel-almaza Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading