-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add custom log source support #28745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=43256912 --os-family=ubuntu Note: This applies to commit 89f9d4b |
Regression DetectorRegression Detector ResultsRun ID: 0b4c6fcd-19c2-4360-aaee-494e8f5e6622 Metrics dashboard Target profiles Baseline: 7f04426 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
➖ | idle | memory utilization | +0.14 | [+0.10, +0.17] | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | Logs |
➖ | pycheck_lots_of_tags | % cpu utilization | -0.01 | [-2.47, +2.44] | Logs |
➖ | otel_to_otel_logs | ingress throughput | -0.24 | [-1.05, +0.58] | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.37 | [-1.16, +0.42] | Logs |
➖ | basic_py_check | % cpu utilization | -0.48 | [-3.08, +2.11] | Logs |
➖ | file_tree | memory utilization | -0.72 | [-0.81, -0.63] | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -2.60 | [-14.88, +9.69] | Logs |
Bounds Checks
perf | experiment | bounds_check_name | replicates_passed |
---|---|---|---|
✅ | idle | memory_usage | 10/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
comp/otelcol/otlp/components/exporter/logsagentexporter/logs_exporter_test.go
Show resolved
Hide resolved
comp/otelcol/otlp/components/exporter/logsagentexporter/logs_exporter_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
🚂 MergeQueue: waiting for PR to be ready This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
This PR adds support to setting the log source via resource attribute OR log attribute
datadog.log.source
. If this is not set, it falls back to the previous behaviour (hardcoded log source).This change is applied in all three paths:
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Resource attribute:
Set resource attribute datadog.log.source and send logs. Ensure the source is being populated in the app.
Log attribute:
Set log attribute datadog.log.source and send logs. Ensure the source is being populated in the app.
You can use the following app to emit the logs: