You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go upgrade is causing issue on the Agent side (go tests are taking way longer) and the version mismatch between this repo and the Agent repo is blocking 7.47 preparation
From what I'm seeing on main of datadog-agent (here), the go 1.19.10 upgrade (from #402) was only done in 7.46.x of datadog-agent, and not in main (DataDog/datadog-agent#17619), therefore even with this revert, datadog-agent-buildimages and datadog-agent are in incompatible states (which prevents using new images in datadog-agent). I see two options:
I think 1.19.10 is desirable in any case so my guess is that we should port DataDog/datadog-agent#17619 to main imho
👍 In that case, let's merge this PR, and update main of datadog-agent with the image from this PR's merge + the port of DataDog/datadog-agent#17619. Let's do this ASAP to unblock other teams that need to do their own changes to the buildimages.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go upgrade is causing issue on the Agent side (go tests are taking way longer) and the version mismatch between this repo and the Agent repo is blocking 7.47 preparation