-
-
Notifications
You must be signed in to change notification settings - Fork 3
setup-and-boot-menus: Mount a bootable drive instead of UEFI shell #859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modified test case fails in this pipeline:
Parse One Time Boot Menu :: Test entering into User Password Manag... | FAIL |
[ No bootable media found ] does not contain value 'QEMU QEMU USB HARDDRIVE'.
If it depends on some external PR, please reference it.
It requires * edit |
Yes, I mean pipeline, I do not run anything myself here. I just want to ensure that we do not accustomed to merging PRs with CI checks failing. I have already enabled the requirements for the CI to pass prior merging. So we need to (preferably) either fix it or disable this failing case until resolved. |
b679186
to
1017c8a
Compare
@macpijan The Additionally a Not every test case had been run by the time I'm writing this. Especially the |
Only |
@macpijan I am a bit troubled with the results of CI. What's worse is that some PRs, the newest one being #842, actually have this test PASS. It's like the option appears and disappears randomly on both v0.2.0 and v0.2.1 release for QEMU. |
That's the first Action to fail because of missing UEFI Shell https://github.com/Dasharo/open-source-firmware-validation/actions/runs/15215838318. That also is the first Action to fail because of the missing CPU throttling option too. Everything seems to indicate that it's the v0.2.1 release that removed the throttling option as well as UEFI shell, but nothing like that changed in the configs, and when booting v0.2.0 manually I can't see the option too. |
@macpijan I've been searching through the changes since v0.2.0 and it seems that the throttling menu options were reworked by @miczyg1 about a year ago. This commit made the cPU throttling disabled by default, and QEMU was never actually explicitly adding it in its coreboot configs. Due to this change the option has been removed from the Setup menu. By adding a config option the entry in the menu can be restored, but the menu has changed. It now shows two lines, one of which is readonly. The test has to be modified anyway. |
057a7f3
to
4735c10
Compare
The reworked Power Management menu is too big to fit on one screen. I've tried implementing parsing multiscreen menus, but that seems a little too complex for now, so I've just skipped the last line check for this one menu. |
4735c10
to
4206d41
Compare
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
4206d41
to
2d1f094
Compare
Fixes the test always FAILing because UEFI Shell is no longer distributed with Dasharo
setup-and-boot-menus_log.zip