SecureBootConfigDxe: Implement parsing missing hashes #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some hashes were simply ignored (lack of all CompareGuid in conditions) and it caused the browser to enter an infinite loop. Because CertList variable was never updated, the exit condition for the while loop never met. Also add formatting for displaying image hashes or certificate hashes instead of prue GUIDs. Fixes Dasharo/dasharo-issues#1365 TEST=Enroll DTS grubx64.efi to DB then delete its signature from DB using the Secure Boot menu on QEMU OVMF. Signed-off-by: Michał Żygowski <[email protected]>
|
@miczyg1 I wonder what upstream would say about that. |
They should probably accept that, because it is clearly full of bugs... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some hashes were simply ignored (lack of all CompareGuid in conditions) and it caused the browser to enter an infinite loop. Because CertList variable was never updated, the exit condition for the while loop never met.
Also add formatting for displaying image hashes or certificate hashes instead of prue GUIDs.
Fixes Dasharo/dasharo-issues#1365
TEST=Enroll DTS grubx64.efi to DB then delete its signature from DB using the Secure Boot menu on QEMU OVMF.