Skip to content

Migrate docs to mkdocs #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

PLangowski
Copy link

No description provided.

Signed-off-by: Pawel Langowski <[email protected]>
@@ -110,18 +110,11 @@ to generate detailed code documentation automatically.
To generate the documentation run the following:

```bash
(venv) make html
(venv) mkdocs serve
python -m http.server 8000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mkdocs serve already starts http server, so below python command should not be necessary anymore

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PLangowski do you plan to address this?

@miczyg1
Copy link
Contributor

miczyg1 commented Jun 24, 2025

Comparing the overall look and feel

Before:
image

After:

image

In my opinion it looks so much worse...

It was @macpijan idea/request to migrate to mkdocs: #5 (comment) so maybe he can review as well.

@miczyg1 miczyg1 requested a review from macpijan June 24, 2025 08:20
@PLangowski
Copy link
Author

@miczyg1 I agree, it's much less readable.

@PLangowski
Copy link
Author

@macpijan Have you looked at this?

@PLangowski PLangowski mentioned this pull request Jul 1, 2025
@pietrushnic
Copy link
Contributor

@macpijan we would like to have the release by the end of the week. We would appreciate your review and opinion about mkdocs vs sphinix. I would also prefer mkdocs, but the question is how to make it look reasonable.

@miczyg1
Copy link
Contributor

miczyg1 commented Jul 2, 2025

@miczyg1 I agree, it's much less readable.

Have you researched alternative themes or mkdocs @PLangowski ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants