Skip to content

_WD_GetElementFromPoint: Detect invalid coordinates #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Conversation

Danp2
Copy link
Owner

@Danp2 Danp2 commented Aug 14, 2023

Pull request

Proposed changes

Return additional error code to indicate invalid parameters.

Checklist

Put an x in the boxes that apply. If you're unsure about any of them, don't hesitate to ask. We are here to help!

This is simply a reminder of what we are going to look for before merging your code.

  • I have read and noticed the CODE OF CONDUCT document
  • I have read and noticed the CONTRIBUTING document
  • I have added necessary documentation or screenshots (if appropriate)

Types of changes

Please check x the type of change your PR introduces:

  • Bugfix (change which fixes an issue)
  • Feature (change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (functional, structural)
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

Empty string is returned, but no error code is generated

What is the new behavior?

Sets @err to $_WD_ERROR_InvalidArgue if a negative coordinate is detected

Additional context

Add any other context about the problem here.

System under test

Please complete the following information.

  • OS: [e.g. Windows 10]
  • OS Arch.: [e.g. X64]
  • Browser [e.g. firefox]
  • Browser version [e.g. 96.0.3]

@Danp2 Danp2 changed the title Detect invalid coordinates _WD_GetElementFromPoint: Detect invalid coordinates Aug 14, 2023
@mlipok
Copy link
Contributor

mlipok commented Aug 14, 2023

Looks good as so far.

@Danp2 Danp2 marked this pull request as ready for review August 14, 2023 15:03
@Danp2 Danp2 merged commit 585910c into master Aug 14, 2023
@Danp2 Danp2 deleted the ElementFromPoint branch August 14, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants