Skip to content

Detailed error reporting #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 30, 2023
Merged

Detailed error reporting #448

merged 7 commits into from
Mar 30, 2023

Conversation

Danp2
Copy link
Owner

@Danp2 Danp2 commented Mar 25, 2023

Pull request

Proposed changes

Allow choice between detailed and summary error reporting

Checklist

Put an x in the boxes that apply. If you're unsure about any of them, don't hesitate to ask. We are here to help!

This is simply a reminder of what we are going to look for before merging your code.

  • I have read and noticed the CODE OF CONDUCT document
  • I have read and noticed the CONTRIBUTING document
  • I have added necessary documentation or screenshots (if appropriate)

Types of changes

Please check x the type of change your PR introduces:

  • Bugfix (change which fixes an issue)
  • Feature (change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (functional, structural)
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

Some UDFs set a single error code, such as $_WD_ERROR_Exception, to indicate that an error occurred.

What is the new behavior?

By enabling detailed error reporting via _WD_Option("DetailErrors", True), these UDFs will no longer modify the error code that was set by a prior UDF call.

Additional context

@Danp2 Danp2 linked an issue Mar 25, 2023 that may be closed by this pull request
@mlipok
Copy link
Contributor

mlipok commented Mar 25, 2023

Looks good

@Danp2
Copy link
Owner Author

Danp2 commented Mar 25, 2023

Still need to address #444 (comment).

@Danp2 Danp2 merged commit e937c55 into master Mar 30, 2023
@Danp2 Danp2 deleted the dp_errorlevel branch March 30, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$iErr = $_WD_ERROR_Exception and re-ordering $_WD_ERROR_*
2 participants