Skip to content

_WD_Alert 'status' return success on False #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 9, 2022

Conversation

mlipok
Copy link
Contributor

@mlipok mlipok commented Aug 8, 2022

Pull request

Proposed changes

If function check the status and it is obvious that on false there should be Error , and in this particular case as this is obvious and expected behavior of checking status it should not be reported to user as error.

Checklist

  • I have read and noticed the CODE OF CONDUCT document
  • I have read and noticed the CONTRIBUTING document
  • I have added necessary documentation or screenshots (if appropriate)

Types of changes

  • Bugfix (change which fixes an issue)
  • Feature (change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (functional, structural)
  • Documentation content changes
  • Other (please describe) - wondering if it is SCRIPT BREAKING CHANGE ?

What is the current behavior?

+ wd_demo.au3: Running: DemoAlerts
__WD_Get ==> No alert present [12] : HTTP status = 404
_WD_Alert ==> No alert present [12] : Parameters:   Command=status   Option=Default
wd_demo.au3: (522) : Alert Detected => False

What is the new behavior?

+ wd_demo.au3: Running: DemoAlerts
__WD_Get ==> No alert present [12] : HTTP status = 404
wd_demo.au3: (522) : Alert Detected => False

Additional context

was discussed here:
#371 (comment)

System under test

not related

@mlipok mlipok marked this pull request as ready for review August 8, 2022 14:58
@Danp2 Danp2 merged commit 40bf680 into Danp2:master Aug 9, 2022
@mlipok mlipok deleted the ml_WD_Alert_SuccessOnFalse branch August 9, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants