Skip to content

Examples #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Examples #320

wants to merge 10 commits into from

Conversation

mlipok
Copy link
Contributor

@mlipok mlipok commented May 30, 2022

Pull request

Proposed changes

#133

Checklist

  • I have read and noticed the CODE OF CONDUCT document
  • I have read and noticed the CONTRIBUTING document
  • I have added necessary documentation or screenshots (if appropriate)

Types of changes

Please check x the type of change your PR introduces:

  • Bugfix (change which fixes an issue)
  • Feature (change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (functional, structural)
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

#133

What is the new behavior?

Strarting with examples

Additional context

#133

System under test

Not related

@mlipok
Copy link
Contributor Author

mlipok commented May 30, 2022

@Danp2 before I start to work on examples please review what I got so far.

@mlipok mlipok marked this pull request as ready for review May 30, 2022 23:19
@mlipok
Copy link
Contributor Author

mlipok commented May 30, 2022

btw.
@sven-seyfert please take a look.

On the list Types of changes there is lack of Examples

@Danp2
Copy link
Owner

Danp2 commented May 31, 2022

On the list Types of changes there is lack of Examples

I'm not sure that this warrants a new category. I would suggest using Project since it covers documentation.

@Danp2
Copy link
Owner

Danp2 commented May 31, 2022

I think that your proposal is too complex. For example, do we really need to support headless mode in a basic example?

@mlipok
Copy link
Contributor Author

mlipok commented May 31, 2022

Good point. No.

@mlipok
Copy link
Contributor Author

mlipok commented Jun 1, 2022

Working on this project I get into issue with Failed to decode request as JSON:
Working on fix and FeatureRequest in separate PR.

@mlipok
Copy link
Contributor Author

mlipok commented Jun 1, 2022

Working on this project I get into issue with Failed to decode request as JSON: Working on fix and FeatureRequest in separate PR.

Using Template.au3 together with: #321
I get this messages in console:

__WD_Post ==> Failed to decode request as JSON (22) HTTP status = 400 : ResponseText={"value":{"error":"invalid argument","message":"Failed to decode request as JSON: ","stacktrace":"Syntax error at :1:0"}}...
_WD_CreateSession: {"value":{"error":"invalid argument","message":"Failed to decode request as JSON: ","stacktrace":"Syntax error at :1:0"}}
_WD_CreateSession ==> Failed to decode request as JSON (22) HTTP status = 400

WIP

@mlipok mlipok marked this pull request as draft June 1, 2022 09:27
@mlipok
Copy link
Contributor Author

mlipok commented Jun 8, 2022

@Danp2 please check if this what we currently have here is good start for making examples.

@mlipok mlipok closed this Jul 25, 2022
@mlipok
Copy link
Contributor Author

mlipok commented Jul 25, 2022

Need to CleanUp some projectcs will back with this proposals later at some indefinite time.

@mlipok mlipok deleted the Examples branch July 25, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants