-
Notifications
You must be signed in to change notification settings - Fork 23
wd_demo: review all "Demo****" function #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I don't get these errors when running the version of wd_demo in master branch. |
It depends on driver, browser, windows versions. |
And they are not all. |
Theoretically, it shouldn't matter. In the real world, we both know that some browsers / drivers occasionally behave differently. If there are certain combinations that don't work as expected, then you should list them here.
I'm not sure what you are trying to say here. |
Thats the plan to check and enlist them. |
I see you start enlisting them here: So I propose to close my ISSUE and stick with your's. |
Sorry... I forgot that this issue already existed. |
No problem now they are connected. |
I will check this on my way. |
FIREFOX: DemoElements
|
FIREFOX: DemoScript
|
FIREFOX: DemoFrames
|
Take a look on this errors. |
I don't have time to redo all these tests. #267 resolved the open issues that I previously found. I ran DemoElements and didn't encounter any issues, so it appears to be a problem on your end.
|
Strange. What else can be the reason that we have different results ? |
Which branch are you using for testing? Does it include the latest fixes fro #267? |
That should be fine AFAICS. What combination of Firefox / Geckodriver are you using? |
and
|
Have you tried the 64 bit version? I know that I had issues with 32 bit, but it was related to locating the Firefox binary executable. Not sure this would make any difference, but I see that your Firefox is several versions old. I'm testing with v99.0. |
It was due to the cookie aprovall window which hides contents, and because of this the elements was firing |
Ok... please let me know if you find any other issues that need fixed. 👍 |
I have work in background on fixing this issue |
DemoElements + FireFox _WD_Alert($sSession, 'accept') I get this following message:
|
I cannot duplicate this. Here's the output I get when running DemoElements with logging set to Error only --
The only errors I see here are from your failed _wd_FindElement calls trying to deal with cookies. You need to try to isolate this problem with your Firefox installation. |
In DemoScript() $sValue = _WD_ExecuteScript($sSession, "dslfkjsdklfj;", '{}', Default, $_WD_JSON_Value) returns:
Was it intentionall to initiate error ? |
Yes, but feel free to replace with something more meaningful. |
What was the intention? |
Simply to show the effect of generating a javascript error, so it isn't really needed if you want to remove it or replace it with something more meaningful |
maybe something like: ; proper JavaScript line
$sValue = _WD_ExecuteScript($sSession, "console.log('Hello world!');", '{}', Default, $_WD_JSON_Value)
; invalid JavaScript Line
$sValue = _WD_ExecuteScript($sSession, "console.log('Hello world", '{}', Default, $_WD_JSON_Value) |
Updated OP by adding task |
DemoTimeouts - on FF works fine but on GoogleChrome/MSEdge/Opera - fires error:
Full log for this error
|
This appears to be related to your _Demo_NavigateCheckBanner routine. I don't encounter these "banners" unless I force it to occur by using a proxy. Did you do anything in FF to dispose of the banner or did it not appear at all? |
In all cases it appears, and I click it manually. As for now I only doing research to check which demos are not working well. |
|
I notice problem with |
That is the expected result because the file doesn't exist (as indicated in the filename). You should get the same thing on all browsers. |
Bug report
Describe the bug
This may not be a specific bug, but we have to check all "Demos" step by step on all browsers.
How to reproduce
Run wd_demo.au3

Set debug level to "Error"
Select all "Demos" (except
UserTesting
) and run themExpected behavior
Mostly there should not be any errors, but there are exceptions for example "DemoTimeouts" exptect to TimeOut error was fired.
Screenshots
Expected TimeOut error

Unexpected error:

Additional context
This bug report is only as a start for disscusion.
System under test
All possible cases. If we will have time.
Progress / summary
NID
issue is normal behavior take a look at DemoCookies() waits on NID cookie existence #370'check status'
is expected behavior DemoAlerts() - show that prompt was set #371Screen2.png
_WD_WaitElement ==> User Aborted [17]
The text was updated successfully, but these errors were encountered: