Skip to content

[bug] Change Image placeholder/error parameter #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 10, 2025
Merged

[bug] Change Image placeholder/error parameter #617

merged 4 commits into from
Feb 10, 2025

Conversation

DongJun-H
Copy link
Member

@DongJun-H DongJun-H commented Feb 1, 2025 •
edited
Loading

변경사항

  • AsyncImage 사용시, model에 placeholder/error를 포함시켜 로드했던 것에 대해 AsyncImage의 parameter에 넣도록 분리
  • 기존 RoundImageView 사용시 placeholder parameter type이 Drawable이었던것에 대해 Drawable Id를 전달하도록 변경
    • 이에 영향 받는 내프로필 변경 뷰와 댓글 바텀시트 뷰에 대한 변경
  • 기존 BadgeRoundImageView에서 imageUrl에 대해 String으로 받고있던 것에 대해 Any 타입으로 변경해 여러 타입을 받아올 수 있도록 설정

변경 목적 및 참고

@DongJun-H DongJun-H added the bug Something isn't working label Feb 1, 2025
@DongJun-H DongJun-H requested a review from yuni-ju February 1, 2025 12:47
@DongJun-H DongJun-H self-assigned this Feb 1, 2025
yuni-ju
yuni-ju approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@yuni-ju yuni-ju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 RoundImageView 파라미터들 순서 정리하고 머지 부탁드립니닷!

image

RoundImageView의 customModifier도 modifier로 변경하면 좋을 것 같아요 : )

@DongJun-H DongJun-H merged commit 2014ba9 into develop Feb 10, 2025
1 check failed
@DongJun-H DongJun-H deleted the bug/issue-616 branch February 10, 2025 11:00
@DongJun-H DongJun-H restored the bug/issue-616 branch February 10, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuni-ju yuni-ju yuni-ju approved these changes

Assignees

@DongJun-H DongJun-H

Labels
bug Something isn't working
Projects
DAYO 2.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DongJun-H @yuni-ju