[layout] Add Dayo Loading Component #614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuni-ju
requested changes
Jan 14, 2025
presentation/src/main/java/daily/dayo/presentation/view/Loading.kt
Outdated
Show resolved
Hide resolved
| modifier: Modifier = Modifier, | ||
| message: String = "잠시만 기다려 주세요", | ||
| dimColor: Color = Dark.copy(alpha = 0.4f), | ||
| lottieFile: Int, |
There was a problem hiding this comment.
- lottieFile이 필수 파라미터라면 파라미터 순서를 위쪽으로 올려주세요. 아니면 디폴트 값을 넣어둬도 될 것 같습니다!
- 아래 코드에서 rawResId로 사용되는 것 같은데
@RawReslottieFile: Int 로 어노테이션을 붙이는 것이 좋아보입니다
Suggested change
| lottieFile: Int, | |
| @RawRes lottieFile: Int = R.raw.dayo_loading, |
- 그러면서 디자인에 맞게 기본 lottieModifier 크기도 92x85로 설정 되어있으면 더 편하게 쓸 수 있을 것 같아요!
yuni-ju
requested changes
Jan 15, 2025
Comment on lines
40
to
47
| @RawRes lottieFile: Int = R.raw.dayo_loading, | ||
| lottieModifier: Modifier = Modifier, | ||
| lottieWidth: Dp = 92.dp, | ||
| lottieHeight: Dp = 85.dp, | ||
| isVisible: Boolean, | ||
| modifier: Modifier = Modifier, | ||
| message: String = "잠시만 기다려 주세요", | ||
| message: String = stringResource(id = R.string.loading_default_message), | ||
| dimColor: Color = Dark.copy(alpha = 0.4f), |
There was a problem hiding this comment.
compose 권장 파라미터 순서입니닷!
필수 파라미터인 isVisible을 가장 위로 올려주시면 감사하겠습니다!
yuni-ju
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 사항
구현 내용
Float.MAX_VALUE로 설정해 다른 화면들보다 항상 위에 뜰 수 있도록 설정구현 화면
Screen_Recording_20250114_215730_DAYO.Debug.mp4