-
Notifications
You must be signed in to change notification settings - Fork 0
[layout] Modify Common Component #604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DongJun-H
approved these changes
Dec 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
Custom Theme을 만든 이유!
Material 혹은 Material3에서 제공하는 Typography 타입은 다음과 같습니다.

하지만 우리가 필요한 Typography 타입은 더 다양합니다 !_!
따라서 별도의
DayoTypography
타입을 만들어서 위 스타일을 정의했습니다.참고 사항
feature/issue-592 브랜치(아직 merge되지 않은 #602 PR) 에서 컴포넌트 수정 사항이 있었습니다. 여기서 브랜치를 생성했더니 불필요한 커밋내역까지 보입니다.
[layout] Custom DayoTheme 커밋 이후부터 확인 부탁드립니다...
resolved #603