Skip to content

[layout] Modify Common Component #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Dec 15, 2024
Merged

[layout] Modify Common Component #604

merged 19 commits into from
Dec 15, 2024

Conversation

yuni-ju
Copy link
Member

@yuni-ju yuni-ju commented Dec 13, 2024

작업 내용

  • Custom DayoTheme 만들기
    • 폰트와 배경 색상을 디자인에 맞게 적용
  • 북마크 화면 디자인 참고해서 체크박스, 버튼 컴포넌트 변경

Custom Theme을 만든 이유!

Material 혹은 Material3에서 제공하는 Typography 타입은 다음과 같습니다.
image

하지만 우리가 필요한 Typography 타입은 더 다양합니다 !_!

image

따라서 별도의 DayoTypography타입을 만들어서 위 스타일을 정의했습니다.

참고 사항

feature/issue-592 브랜치(아직 merge되지 않은 #602 PR) 에서 컴포넌트 수정 사항이 있었습니다. 여기서 브랜치를 생성했더니 불필요한 커밋내역까지 보입니다.
[layout] Custom DayoTheme 커밋 이후부터 확인 부탁드립니다...

resolved #603

@yuni-ju yuni-ju requested a review from DongJun-H December 13, 2024 13:30
@yuni-ju yuni-ju self-assigned this Dec 13, 2024
@yuni-ju yuni-ju added the layout label Dec 13, 2024
Copy link
Member

@DongJun-H DongJun-H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yuni-ju yuni-ju merged commit a845de3 into develop Dec 15, 2024
1 check passed
@yuni-ju yuni-ju deleted the layout/issue-603 branch December 15, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[layout] Modify Common Component
2 participants