Improvements to icecast failure handling #1401
Conversation
doug-hoffman
commented
Jan 6, 2023
doug-hoffman
commented
- Add mechanism to persist failure reason while continuing to reconnect
- Add 'warning' attribute for failure conditions that may be temporary, but still need to be reported
- Add logging for failures
- Prevent possibly temporary server-side conditions from blocking reconnect attempts (fixes Icecast 2.3 feed gets stuck offline #1398)
- Detect icecast 2.4 auth failures
- Prevent generic errors from overriding existing error state
|
@doug-hoffman Thanks for the PR. Comment: streaming errors are going to be temporary and once they're addressed, they shouldn't be a long-term issue. The primary sdrtrunk gui's streaming status panel is already kinda busy with several columns and adding another column to that table seems to make it more crowded. Do you think you can achieve the same effect (capture the last error to support troubleshooting) by only including the new column in the playlist editor's streaming configuration table? The primary status panel will show that the feed has some kind of error status which should be a cue to the user to go to the playlist editor to diagnose the issue further. |
- Add mechanism to persist failure reason while continuing to reconnect - Add 'warning' attribute for failure conditions that may be temporary, but still need to be reported - Add logging for failures - Prevent possibly temporary server-side conditions from blocking reconnect attempts - Detect icecast 2.4 auth failures - Prevent generic errors from overriding existing error state
|
Thanks for the feedback. I've dropped the changes to the streaming status panel, so now the last error will only be displayed in the playlist editor. |
|
It would be great to get this update. Is there anything else that needs to be done so that other broadcasters don't get locked in an error state? |
|
I don't think this fixes #1892. I still have issues with feeds to icecast 2.4 breaking after a network disruption, but it did fix my issues with previous versions of icecast. I've not spent much time troubleshooting the 2.4-specific issue. |
