Skip to content

SDRTrunk not resetting JMBE IMBESynthesizer . #2040

Closed
@tadscottsmith

Description

@tadscottsmith

sdrtrunk Version
Latest nightly.

Describe the bug
SDTRunk is not resetting the IMBESynthesizer after each call.

Expected behavior
SDRTrunk should call the getAudioCodec().reset() function to reset the IMBEModelParameters on each new P25P1 call. Currently the IMBEModelParameters are being held across calls which is leading to a slight skew in audio quality, particularly at the beginning of a call.

Additional context
This does not seem to have a huge impact on overall audio quality, so feel free to close if you'd like. For testing purposes, I reset the parameters shortly after mEncryptedCallStateEstablished = true; in the P25P1AudioModule class, but I did not submit a PR since that might not be the ideal location for the code.

Metadata

Metadata

Assignees

Labels

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions