chore: pin html-to-image to 1.11.11
#1963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It might be worth adding that the suspicion is around this PR that was merged into 1.11.12, but it could have been anything in that version or 1.11.13 (latest at this time). See also: this issue. |
J05h-L
force-pushed
the
chore/248372/pin-html-to-image
branch
from
2c93dd1 to
23627d3
Compare
WolfyUK
reviewed
Feb 18, 2025
WolfyUK
previously approved these changes
Feb 18, 2025
WolfyUK
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AB#248372 - AB#249983
See the description in task 249983. In newer versions of this package a change has been introduced where the styling for the charts is not being resolved correctly resulting in the charts displaying incorrectly as images. Worth noting
1.11.11is the most popular version.See below comment from @WolfyUK for likely source.
Change proposed in this pull request
pin the version for
html-to-imageto1.11.11Guidance to review
front-end component can be built locally and using that for the Web app the charts should display correctly when saved. Worth clearing broswer cache as that can preserve styles if you have generated images previously.
A bump to
front-endwill followChecklist (add/remove as appropriate)