-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add support for OpenZeppelin UUPSUpgradeable reinitializer function #874
Merged
TilakMaddy
merged 10 commits into
Cyfrin:dev
from
sumitvekariya:fix/unprotected-initializer-reinitializer-support
Mar 27, 2025
Merged
fix: Add support for OpenZeppelin UUPSUpgradeable reinitializer function #874
TilakMaddy
merged 10 commits into
Cyfrin:dev
from
sumitvekariya:fix/unprotected-initializer-reinitializer-support
Mar 27, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TilakMaddy
reviewed
Mar 27, 2025
TilakMaddy
reviewed
Mar 27, 2025
TilakMaddy
reviewed
Mar 27, 2025
29dd85b
to
27e196b
Compare
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #836, where Aderyn was generating false positives for the "Unprotected Initializer" detector when analyzing contracts that use OpenZeppelin's UUPSUpgradeable
reinitializer(n)
modifier.The detector is now enhanced to recognize both
initializer
andreinitializer
modifiers as adequate protection for initialization functions, thus reducing false positives.Changes
UnprotectedInitializerDetector
to check for modifiers whose names start with "reinitializer", in addition to the existing check for the "initializer" modifier.ReinitializerTest.sol
) with both protected and unprotected initializer functions to validate the changes.Testing
The changes have been tested with:
reinitializer
modifierinitializer
modifierRelated Issue
Fixes: #836