Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env variable support to aderyn.toml #820

Merged
merged 8 commits into from
Mar 10, 2025

Conversation

TilakMaddy
Copy link
Contributor

@TilakMaddy TilakMaddy commented Mar 10, 2025

  • No breaking changes

  • Tests included

Motivation:
So far, on command line, there are no issues. Because the env is inherited from the shell into the current process. For vscode extension, we need to explicitly make this inheritance. But we don't know which shell the user has set all the variables. Therefore, this config allows for the agreement to be made explicit

@TilakMaddy TilakMaddy marked this pull request as ready for review March 10, 2025 11:55
@TilakMaddy TilakMaddy requested a review from alexroan as a code owner March 10, 2025 11:55
@TilakMaddy TilakMaddy marked this pull request as draft March 10, 2025 12:14
@TilakMaddy TilakMaddy marked this pull request as ready for review March 10, 2025 12:30
@TilakMaddy TilakMaddy merged commit 0b0458b into dev Mar 10, 2025
42 checks passed
@TilakMaddy
Copy link
Contributor Author

@alexroan New foundry project added as integration test here. You might want to update your git submodule :)

This was referenced Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant